0507f6a117 Validate message signature encoding (Adam Gibson)
Pull request description:
Fixes#1069.
Before this commit, a non-hex encoded pubkey sent
as part of the privmsg signature raised an Exception,
this commit fixes this, checking the encoding of both
the pubkey and signature fields before sending them
from daemon to client.
ACKs for top commit:
kristapsk:
ACK 0507f6a117. Checked diff between commits, test suite passes, did successful signet coinjoin. Merging.
Tree-SHA512: d6b59fc340b015157544330a0a4624999559d9f2bcc5ee1ef189558bdab5fb2a2cf80287d1020bfe5be1f4919037b794a0fa4bbe2292a80aca0a03e9de23384a
840189cd0a Fix SNICKER daemon startup (Kristaps Kaupe)
Pull request description:
Fixes#1067.
Bug was introduced with 7e73e4caa9 (part of #996) when return value of `start_daemon_on_port()` was changed from `int` to `tuple`.
Top commit has no ACKs.
Tree-SHA512: 76bfbbf89b66d39d277bac4aed515cd251fe5f40e6eaafc2596c2e095a60931f1cddd2b147e4fd51d07c99c6ff8c94bbc2fe661a618da0220ff4924128833031
e7ff25d1ca Fix example date and example output in fidelity bond doc (Kristaps Kaupe)
Pull request description:
Resolves#1071.
Top commit has no ACKs.
Tree-SHA512: 0ae4a130d9fa3cc815e60ee4d03524573b992559e2da768ad0600e350e5a92cf67644d6896a3c84daad02b5161eb9793fbb9cec602e1d79b1f9c5626d91f4ee2
14bed1400a Fix @fort-nix's public orderbook links (Kristaps Kaupe)
Pull request description:
In long-term IMO it would be cool to have some orderbook watcher in the Qt GUI, so it would be easy to view orderbook without running ob-watcher script locally.
Top commit has no ACKs.
Tree-SHA512: 80084a3999da0d31d91d6b7307cdb5362f5c7dbbe142056d5e857fce0d0bc5b027aef1e7a81391c5f0d06b006c698112472682fabffeddfdf0540625a93a8fb0
Fixes#1069.
Before this commit, a non-hex encoded pubkey sent
as part of the privmsg signature raised an Exception,
this commit fixes this, checking the encoding of both
the pubkey and signature fields before sending them
from daemon to client.
af4f071b74 Add Ilita IRC server (.onion) (xanoni)
Pull request description:
- Added Ilita (http://ilitafrzzgxymv6umx2ux7kbz3imyeko6cnqkvy4nisjjj4qpqkrptid.onion)
- Cleaned up server list overall
ACKs for top commit:
kristapsk:
ACK af4f071b74, did successful signet coinjoin.
Tree-SHA512: 0767782a51fc94b474a5a084b84390a67a2b3d9239915df7abaab50a388be918393ef083909f46fb1a7246c4f70556fece94afdfcb11af24b760f0e2230159cc
1e25d1fbbf Allow to not specify rpc_port in config, use network's default then (Kristaps Kaupe)
Pull request description:
I regularly switch between mainnet and signet on my development laptop, this will save little bit of time, one setting less to change each time.
Top commit has no ACKs.
Tree-SHA512: 23122443cbbaeb1cf48a5fd472684d62cb5519c6cc822d4735c0faa98cadc3f08f5c39d963066e5e5a6e1fe6227244c34ea5ed596d7b9d7b8d7da02efb018cb1
21c0e3e758 Implement address labeling (Kristaps Kaupe)
Pull request description:
Adds new method `setlabel` to `wallet-tool.py` that allows to set label for wallet address. Setting it to empty string removes label. Labels are shown as additional column in `display` and `displayall` methods.
Full functionality for now is cli only, in Qt GUI is only read-only displaying implemented.
Top commit has no ACKs.
Tree-SHA512: b24c96d4d57ab75a511474898e9087e8cd5faa0e1e9440ab57e6caafbc442a8b4edbbad5d3dbd67f0ed3a0cd95f9cd059924d28956869456901fb27dba0530d6
Prior to this commit, it was possible for a modified
taker client to get a maker to participate in a join
tx with a size less than their minsize, which could
burn up to an amount of the txfee contribution to
miner fees.
After this commit, the maker stops the coinjoin
coordination when the too-small coinjoin size is seen,
as intended.
Additionally, a check is now in place in the function
`Maker.verify_unsigned_transaction` that the earned
amount is positive, which otherwise could raise an
Exception (but should now be impossible in any case).
Also, changed the default txfee_contibution to zero
as it is of no value to have a nonzero amount.
Also return added for unrecognized orderid, for clearer
error messages.
ba63b01729 Option to skip OS package manager's dependency check (Kristaps Kaupe)
Pull request description:
This is needed to be able to install on Debian and macOS using `install.sh` from user that does not have `sudo` permissions <ins>and for some reason user has all necessary dependencies on the machine but OS package manager this it does not</ins>.
Noticed while migrating my RaspiBolt test setup from Raspberry Pi (which defaults to 32-bit Raspbian as OS) to Odroid-HC4 (which has 64-bit Ubuntu Server instead).
Top commit has no ACKs.
Tree-SHA512: 5be7b9ae04e5227dc386567baf6ad02b0dd77162cb31f81dbf55d5284437decd65c0ad01c7801f3a405735c1f49712811247146eea82bf9bc423bc92f5d2fdb8
Fixes#1027. Previous to this commit, the onion
service used by the payjoin receiver was automatically
served on localhost (at an arbitrary port), after this
commit these values can be specified in the PAYJOIN
section of the config.
1. Moves the JMWalletDaemon service class into
the jmclient package (see the wallet_rpc.py module).
2. Adds dependencies "klein" and "autobahn" to the
jmclient package, as well as "pyjwt".
3. Adds another module websocketserver.py, using
autobahn, to allow the JMWalletDaemon service to
serve subscriptions over a websocket, for e.g.
transaction notifications.
4. Adds tests both for the websocket connection
and for the JSON-RPC HTTP connection.
JmwalletdWebSocketServerFactory.sendTxNotification
sends the json-ified transaction details using
jmbitcoin.human_readable_transaction (as is currently
used in our CLI), along with the txid.
Also adds a coinjoin state update event sent via
the websocket (switch from taker/maker/none).
Require authentication to connect to websocket.
5. Add OpenApi definition of API in yaml;
also auto-create human-readable API docs in markdown.
6. Add fidelity bond function to API
7. Add config read/write route to API
8. Remove snicker rpc calls temporarily
9. Updates to docoinjoin: corrects taker_finished
for this custom case, does not shut down at end.
10. Address detailed review comments of @PulpCattel.
The /utxos route is the equivalent of the showutxos
wallet tool method.
The heartbeat route /session allows a client to
make sure the backend is still running and in the
expected state (but see later commits for the
coinjoin state update via the websocket).
Fixes to sendpayment, the maker service,
the create wallet function.
sendpayment fix
Also substantially improved and made
functional the coinjoin route, a schedule
is now created and a complete taker-side
coinjoin is now possible.
Uses Klein to provide HTTP server support.
Adds cookie based auth to requests (made JWT token
based in later commits).
Basic routes are: /unlock, /lock, /display,
/create of wallet.
Encapsulates WalletDaemon as a Service
Add snicker receiver service start, stop
Adds yg/maker function as stoppable service.
Adds a JMShutdown command to
the AMP protocol, allowing a clean shutdown
of a long running bot (e.g. maker) by shutting
down its message channel connections, without
shutting down the entire process.
Adds payment(direct send) request, first draft
bc71997058 Reorder the tabs in Qt (Wukong)
Pull request description:
The current ordering of the tabs in Qt feels very strange. For example, the "Settings" tab is usually the last tab in most applications, while it's the 2nd tab in JoinMarket-Qt.
This PR reorders the tabs from "JM Wallet, Settings, Coinjoins, Tx History, Coins" to "JM Wallet, Tx History, Coinjoins, , Coins, Settings".
I made the new ordering of the tabs by consulting the Electrum wallet, which has the tab orders of "History, Send, Coins".
ACKs for top commit:
kristapsk:
ACK bc71997058
Tree-SHA512: 8133764152316e31b475a80b7e55cc06f416a93fb787f08cde6935e4c2e5fc8d1b6f9245c11854bc13c8e2d274be424099bbcc07a1f5be860da3a5e4dca433d4
3f5abeec14 Fix help description of yg's command line txfee options (Kristaps Kaupe)
Pull request description:
Help output description of yield generator's `--txfee` command line option is currently wrong.
Top commit has no ACKs.
Tree-SHA512: ae1d1f9652df313fd0e9d4f6c16583a70f0666f54c03a2e1c03318a52b688c52787d737d75b9e084a0ac64af4a08f8380ca15644552b5f788fe7be235246a74c
df5f241f29 Add configurable miner fee randomization factor (Kristaps Kaupe)
Pull request description:
Defaults to previously hardcoded 0.2 (+/- 20%).
Resolves#1009.
What I don't like is that we now have `tx_fees` and `tx_fees_factor` under `[POLICY]` and `txfee` and `txfee_factor` under `[YIELDGENERATOR]`, which may be confusing, but I don't see a good solution to that (apart from getting rid of yg txfee configs).
Top commit has no ACKs.
Tree-SHA512: 0c7fddf5209a74fa8d0dc2b195b1125b819e48db3c6aa8543a0c305a8ad19a5e02ada916e36325acbbd3a9114a33c0183ee49772ab37769de0f538113e506d5c
Adam Gibson
Kristaps Kaupe
xanoni
nixbitcoin
Adam Gibson
unofficial bisq contributor
dependabot[bot]
abhishek0405