Previously, if a bot reconnected and encountered a nick
collision, it would append '_' and connect, but counterparties
would ignore appended characters after NICK_MAX_ENCODED+2, and
so would send to the other nick. This happens in network
connection failure scenarios.
Strategy here is to simply insist on regaining the nick on that
message channel where it has been lost, retrying every 10s.
There is also a loud warning message printed.
This fixes the non-deterministic failures of the test_schedule tests.
It does so by addressing the underlying issue, which is described in
be made configurable in future, but assessed as not worth it here.
It will end up showing very small and actually wrong numbers like
5.38939837311e-11 % or even -1.48880395563e-11 % if it's newly funded
wallet with no coinjoins happened yet.
Prior to this commit, if a user chose to reject offers, or the offers
choosing process failed for another reason, the on_finished_callback
of the Taker was called, as well as the return value passed to the
client protocol being "False", and both execution paths called
reactor.stop(), resulting in an Exception in twisted (a reactor can
only be stopped once). This commit fixes that by only stopping the
reactor in the client protocol code (and only in cases of 1
sendpayment; for multiple tx runs, it waits and restarts).
4e6bee3 choose correct offer types for non-sw taker (AdamISZ)
619b4a1 Add support for taker using a non-segwit wallet As for maker, to use this feature set segwit = false in the POLICY section of the config file. This commit does *not* include support in the GUI. Additionally, minor fixes to utility scripts for non-sw wallets, and updated add-utxo tool to support non-sw wallets. Bugfixes to wallet_utils to support non-sw wallets and signmessage. (AdamISZ)
As for maker, to use this feature set segwit = false
in the POLICY section of the config file.
This commit does *not* include support in the GUI.
Additionally, minor fixes to utility scripts for non-sw wallets,
and updated add-utxo tool to support non-sw wallets.
Bugfixes to wallet_utils to support non-sw wallets
and signmessage.
605eebe add test cases for maker::verify_unsigned_tx (undeath)
d2196ad fix maker crash when verifying transaction with p2sh output in non-sw mode (undeath)
715985d add support for non-segwit maker (undeath)
This comment was formerly housed at another repo, which has now
been made inactive and the comment was removed. Note that this
manual process will be superceded soon by a change to the
installation script.
91ffa6c Add support for core's multiwallet feature (chris-belcher)
Tree-SHA512: 16f87c8c04dbb5e57d226e0dd1ed598cd6734e5b5cb2eb5f17fccd2802463800d07f7a649ff024809bc8361bc89de7e2637f086124b4af895d1aa107b3f9c999
This case can happen if you sweep to a destination under the control
of your Core wallet (although it's rare). This is not actually a problem,
since that address neither was nor will be Joinmarket's. Hence show a
warning but continue. Also add a comment to BitcoinCoreInterface.im-
port_addresses, to note that it must *only* be used for initial sync,
since it has a risk of shutting down the program.
This fails (sys.exit) when importaddress throws the error corresponding to
Core wallet already owning the key corresponding to an address, and gives
brief advice how the error can be fixed.
It is not considered safe to simply ignore this error in case address reuse
or coins being sent to an address the user doesn't control, occurs.
Signatures sent a second time now are correctly ignored, rather than prompting
a removal for the utxo entry which fails since it's already been removed.
Also corrects the case where a junk signature can trigger a crash in verify_tx_input,
if its script deserialization results in non-string entries (integer or None).
Test cases in test_taker updated to include these error cases, now passing.
AdamISZ
undeath
Kristaps Kaupe
fivepiece
Adlai Chandrasekhar
James Hilliard
chris-belcher
mecampbellsoup
Kristaps Kaupe