03ea5bb762 Add command line option support and verbose output option (Kristaps Kaupe)
Pull request description:
Verbose output is sometimes useful when tests fail, to get full error output, instead of truncated one.
Top commit has no ACKs.
Tree-SHA512: 83dcc31c2a889bd45a5e820bfeb3a6fb9fc8f5d781cf8bd29c5ffc2bdf1ae7ebdb9ef17c625f046b398531d8ffbda4ac80a373f0a4a76d3aa7844b09406d9ba2
60e2beaa78 Move wallet_utils tests to test suite (Kristaps Kaupe)
Pull request description:
Top commit has no ACKs.
Tree-SHA512: ef40d994e5b7e6305994e859080123d3c739a030973dce43df122b27a1de33e9ac09dbb967e691774a5381b945950fedc89435562c6f4391bd3feef77562f682
9ea0a732f2 Hide "Total balance" in wallet-tool when only single mixdepth is displayed (Kristaps Kaupe)
Pull request description:
Addresses minor concern raised by @AdamISZ [here](https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/820#issuecomment-792308720) that `wallet-tool.py -m` now displays "Total balance" row which actually shows not total wallet balance but balance of a single choosen mixdepth.
Top commit has no ACKs.
Tree-SHA512: 26492674df0d66aed88b89c5f23223eae2eeb034b6be8f8029f3065a1ae51bbc123e82aecb01d54ae0b0a0e23c435c6d3a9c696731cb3227b125b5fe4ef8202e
In case of all-in-one (client and daemon in same process,
the default), this commit ensures that if there was a port
conflict and the port number for the daemon was incremented,
the client connects to the newly created protocol instance.
And this applies to all three protocols (jm, snicker, bip78).
This PR creates a client-daemon protocol for
the BIP78 sender, using the base protocol
`HTTPPassThrough` which provides tor and non-tor
agents with POST and GET request functionality.
As for Joinmarket coinjoins, the use of an in-process
daemon is the default option, but it can be isolated
by changing the `[DAEMON]` section of the config.
The receiver side of BIP78 will be addressed in a
future PR.
Before this commit, if receiving payjoin (BIP78) via
JoinmarketQt, after the payjoin was successfully broadcast
by the sender, and the new utxo(s) recognized in the wallet,
the Qt app nevertheless attempted to broadcast the initial
payment transaction as the delayed call was not getting canceled
by the JMBIP78ReceiverManager (this attempt of course always
failed as the coins were spent, so was not dangerous, but merely
confusing). This is now fixed.
Before this commit, the check of receiver inputs in the
proposed PSBT from the receiver was erroneously failing,
if the number of sender inputs was greater than 1, because
the list of receiver input indices was not populated correctly
before the check. This commit fixes this bug.
fc74c94c35 add missing jquery lib to ob-watcher.py (undeath)
5f8219617d fix ob-watcher.py serving from relative location (undeath)
ddcfd608e4 simplify ob-watcher.py static file serving code (undeath)
693609e095 Vendorize js and css dependencies (3nprob)
Pull request description:
Fixes#804
While integrity checks could solve the first point, IMO it makes more sense to host these locally as well. This fixes that.
ACKs for top commit:
kristapsk:
ACK fc74c94c35
Tree-SHA512: f898b996943a6cdc47d84a2bbb61e6a591428a6388bb3b71853ce4a92dd139ff05d288544560d7f58903efaf242de39589839991c0595dd0db42ca007f5c838d
b1ac4f625c Pin cryptography module to v3.3.2 (Kristaps Kaupe)
Pull request description:
Newer versions instroduces Rust as a dependency, which causes problems for some people / platforms - https://github.com/pyca/cryptography/issues/5771 .
Top commit has no ACKs.
Tree-SHA512: 1efb4916cc94f30217f8cc19bbedc10350363b1f00d0c57410d3959082789fd43c5f8b739eafc1ef40ae4e431123b69dc787aa712b8231a566257ed5deb8f369
Prior to this commit, several test functions were using
"True" to flag internal and "False" to flag external for
the HD branch for the wallet, but we now use BaseWallet vars
ADDRESS_TYPE_[IN/EX]TERNAL (1/0), so this
is changed to explicitly reference those. There is no change
to the live code (which calls get_[internal/external]_addr).
In addition _index_cache updates in wallet are protected
with a wrapper function to ensure that the branch requested
is valid.
Tests pass both before and after this change.
Adam Gibson
Kristaps Kaupe
openoms
undeath
Gálli Zoltán
3nprob
Nicolas Kuttler
