Prior to this commit, if non-self broadcast was enabled
but the counterparty chosen did not broadcast, the transaction
would remain unbroadcast.
After this commit, the Taker checks, after the configured
value of TIMEOUT.unconfirm_timeout_sec (default 90s), the
Taker will broadcast the transaction.
Also amended default config comment for this function.
5c85a3d979 Log sendrawtransaction errors as warning not debug (Kristaps Kaupe)
Pull request description:
Before this change `sendrawtransaction` errors in `pushtx()` are logged as debug, not warning. But default `console_log_level` is `INFO`. This is important enough information for the user to change log level here.
Before:
```
Would you like to push to the network? (y/n):y
2020-09-09 23:54:26,199 [ERROR] Transaction broadcast failed!
```
After:
```
Would you like to push to the network? (y/n):y
2020-09-09 23:54:26,198 [WARNING] error pushing = -26 dust (code 64)
2020-09-09 23:54:26,199 [ERROR] Transaction broadcast failed!
```
Somewhat related to #600.
Top commit has no ACKs.
Tree-SHA512: 0148e38ec7ae32156c02db76e52ce26920c2815665ced9b7779c1543adb66beead02b32d8891149f848dcd0bd9ff0b6a9a08c22ebfec55b6ad2ace026e1c9b58
0e5eb2f3b1 More verbose absurd fee exception message (Kristaps Kaupe)
Pull request description:
Display both sat/vkB and sat/vB values as we already do in other places, otherwise units may cause confusion for new users, and output both absurd fee value as well as estimated fee rate. This may help in supporting other users via Telegram, IRC, etc.
Top commit has no ACKs.
Tree-SHA512: 4c4c67399f8c427bd7e9aef71fbe6b7f748855b1163f97daa665c689e39be3bf33202ec44a4e2678f81ebb5c17d8b1a47524d86ea68410c096c39e98b0fda028
Prior to this commit, users setting the POLICY config
option `tx_broadcast` to anything other than `self` would
cause a crash after the merge of #536 due to a bin/hex
conversion failure (before this merge, the tx would simply
fail to broadcast).
This commit adds a `JMTXBroadcast` AMP command so that makers
can send arbitrary transactions from daemon to client, for
broadcast via the blockchain interface. This allows the
existing code in `taker.push()` to function correctly, after
fixing the bin/hex conversion bug. Hence users can now select
`random-peer` or `not-self` and the transaction will be
broadcast as expected according to the comments, and the
WalletService will react to the broadcast just as it does
currently for self-broadcast.
Note that this change will be ineffective if the counterparties
do not support it; the transaction will simply remain un-broadcast.
a70329126b Bump coveragepy to fix pytest on python 3.8 (Alessio Caiazza)
Pull request description:
Python 3.8 was not supported before coveragepy v5.0a4
https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst#version-50a4-----2018-11-25
The bump is big, but tests are green
ACKs for top commit:
jules23:
TestedACK a703291 I am now able to run the test suite with Python 3.8.5. Thanks for taking care of this!
kristapsk:
ACK a70329126b. Tested that it fixes tests with Python 3.8.2 and didn't break anything with Python 3.6.10.
Tree-SHA512: 97c2c17f79943d0d3fb1ff50051712a7116bec4769672081f5d270c4b868c083c0c9c99fdccbf40d43f1650d9dc092157414a3aa1c6c375aaaa5220cac8adf7c
Error message about missing matplotlib is only correct in case of
exception during `import matplotlib`. If there is fatal exception
later, it is some other issue and it's better display it as is. On a
RaspiBolt for me `import matplotlib.pyplot as plt` causes
"ImportError: libopenjp2.so.7: cannot open shared object file: No such file or directory".
5ca78c29ea install.sh now works on macOS, no need to follow more complicated guide (Kristaps Kaupe)
Pull request description:
Top commit has no ACKs.
Tree-SHA512: 1e28e8b6c907429e488cbb284fccb7934cd8be83b92bf18e09169feaf31ca0729e70cbd4894259505e87cffd34e55773abf46fa4229cbb47c5396f285f86c2cb
fd9d98fd09Fixes#639. Allow export of private keys in Qt. (Adam Gibson)
Pull request description:
Additionally, we add a note to wif_to_privkey()
in jmclient.cryptoenging.BTCEngine because the
'keytype' variable constructed there is not currently
usabe, and we remove a check of that keytype in
the add_utxo script used for PoDLE (it is not relevant).
ACKs for top commit:
kristapsk:
ACK fd9d98fd09
Tree-SHA512: 161c8cfab80b7eef04ce0f22253946530121e4827769096e80e3019529a6736c2a5525188ef04c695c8f0db704da144648732d5cea026667fbf4b047db973abd
Additionally, we add a note to wif_to_privkey()
in jmclient.cryptoenging.BTCEngine because the
'keytype' variable constructed there is not currently
usabe, and we remove a check of that keytype in
the add_utxo script used for PoDLE (it is not relevant).
In this commit, the jmclient.payjoin module now supports
sending payments to BIP21 URIs where the pj= parameter is
to a hidden service address.
Additionally, the test/payjoinclient and test/payjoinserver
modules are edited to support optionally testing payments to
an ephemeral hidden service.
nixbitcoin
Adam Gibson
Tim Akinbo
Kristaps Kaupe
Alessio Caiazza
Jules Comte
James Hilliard