Browse Source

Fix bug: user rejects offers resulted in crash

If a user doing sendpayment decided to reject the offered fees,
before this commit this resulted in a crash because the call
to Taker.on_finished_callback was passed with fromtx=True for
a single line schedule, which attempts to restart. fromtx should
have been set to False when it is the last item in the schedule
(in this case, both first and last). This incorrect argument
existed before restart-with-subset but was then harmless, now
it attempts to recover with no Taker.nonrespondants and crashes.
Fix is simply to provide the right second argument (False) to
the function call.
master
AdamISZ 8 years ago
parent
commit
f1e3476a64
No known key found for this signature in database
GPG Key ID: B3AE09F1E9A3197A
  1. 2
      jmclient/jmclient/client_protocol.py

2
jmclient/jmclient/client_protocol.py

@ -405,7 +405,7 @@ class JMTakerClientProtocol(JMClientProtocol):
#In single sendpayments, allow immediate quit.
#This could be an optional feature also for multi-entry schedules,
#but is not the functionality desired in general (tumbler).
self.client.on_finished_callback(False, True, 0.0)
self.client.on_finished_callback(False, False, 0.0)
return {'accepted': True}
amt, cmt, rev, foffers = retval[1:]
d = self.callRemote(commands.JMFill,

Loading…
Cancel
Save