From f1e3476a64cadc0bf9fe9f3c90ff97fd7bb7d5ca Mon Sep 17 00:00:00 2001 From: AdamISZ Date: Fri, 20 Jul 2018 20:06:58 +0200 Subject: [PATCH] Fix bug: user rejects offers resulted in crash If a user doing sendpayment decided to reject the offered fees, before this commit this resulted in a crash because the call to Taker.on_finished_callback was passed with fromtx=True for a single line schedule, which attempts to restart. fromtx should have been set to False when it is the last item in the schedule (in this case, both first and last). This incorrect argument existed before restart-with-subset but was then harmless, now it attempts to recover with no Taker.nonrespondants and crashes. Fix is simply to provide the right second argument (False) to the function call. --- jmclient/jmclient/client_protocol.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jmclient/jmclient/client_protocol.py b/jmclient/jmclient/client_protocol.py index 4e87c57..fb771c1 100644 --- a/jmclient/jmclient/client_protocol.py +++ b/jmclient/jmclient/client_protocol.py @@ -405,7 +405,7 @@ class JMTakerClientProtocol(JMClientProtocol): #In single sendpayments, allow immediate quit. #This could be an optional feature also for multi-entry schedules, #but is not the functionality desired in general (tumbler). - self.client.on_finished_callback(False, True, 0.0) + self.client.on_finished_callback(False, False, 0.0) return {'accepted': True} amt, cmt, rev, foffers = retval[1:] d = self.callRemote(commands.JMFill,