Browse Source

Merge JoinMarket-Org/joinmarket-clientserver#1771: build(docker): update to debian bookworm

cf5184f244 test(ci): build docker image in github workflow (theborakompanioni)
9d8988a1fd build(docker): update to debian bookworm (theborakompanioni)

Pull request description:

  Updates `Dockerfile` base image from `debian:bullseye-slim` to `debian:bookworm-slim`.

  Bullseye default version of [`autoconf`](https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1703) is incompatible with [`libffi` v3.4.6](cbd88681f9) (needed 2.71, installed v1.69):

  ```
  534.3 v3.4.6.tar.gz: OK
  534.3 /jm/clientserver/deps/libffi-3.4.6 /jm/clientserver/deps /jm/clientserver
  [...]
  536.0 configure.ac:3: error: Autoconf version 2.71 or higher is required
  536.0 configure.ac:3: the top level
  536.0 autom4te: /usr/bin/m4 failed with exit status: 63
  536.0 aclocal: error: /usr/bin/autom4te failed with exit status: 63
  536.0 autoreconf: aclocal failed with exit status: 63
  536.0 ./install.sh: line 247: ./configure: No such file or directory
  536.0 make: *** No rule to make target 'uninstall'.  Stop.
  536.0 make: *** No targets specified and no makefile found.  Stop.
  536.0 make: *** No rule to make target 'check'.  Stop.
  536.0 Libffi was not built. Exiting.
  ```

  ## How to test
  Run `docker build -t joinmarket-clientserver-pr-1771 .` and check if image is built successfully.

ACKs for top commit:
  kristapsk:
    cr utACK cf5184f244

Tree-SHA512: 7fc17f4326d026cc8f925893e3dc4f867dfa0aaa763d64fe5a9205acdb8d14aa615fa611cffc84f6a362d0cc7456bfe2b165949706332b1fd4b805a95d4bf524
master
merge-script 8 months ago
parent
commit
68d36a06c2
No known key found for this signature in database
GPG Key ID: 33E472FE870C7E5D
  1. 33
      .github/workflows/build-docker.yml
  2. 4
      Dockerfile

33
.github/workflows/build-docker.yml

@ -0,0 +1,33 @@
name: Build Docker image
on:
pull_request:
push:
branches:
- master
env:
DOCKER_IMAGE_NAME: joinmarket-clientserver
DOCKER_IMAGE_TAG: test
jobs:
docker:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Build
uses: docker/build-push-action@v6
env:
SOURCE_DATE_EPOCH: 0
with:
load: true
push: false
tags: ${{ env.DOCKER_IMAGE_NAME }}:${{ env.DOCKER_IMAGE_TAG }}

4
Dockerfile

@ -1,4 +1,4 @@
FROM debian:bullseye-slim
FROM debian:bookworm-slim
RUN mkdir -p /jm/clientserver
WORKDIR /jm/clientserver
@ -7,8 +7,10 @@ COPY . .
RUN apt-get update && apt-get install -y --no-install-recommends gnupg ca-certificates=* curl=* \
python3-pip=* python3=* \
&& pip3 config set global.break-system-packages true \
&& pip3 install 'wheel>=0.35.1' \
&& ./install.sh --docker-install \
&& apt-get purge -y --autoremove python3-pip \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

Loading…
Cancel
Save