SomberNight
e097a3f875
CI: add some task dependencies
...
run linter first, then tests, then binary builds
3 years ago
ghost43
8ef395f4f3
Merge pull request #8337 from SomberNight/202304_flake8_bugbear
...
CI: flake8-bugbear
3 years ago
SomberNight
4cbb8399d2
CI: also run flake8-bugbear, as part of flake8
3 years ago
SomberNight
4219022c2e
fix flake8-bugbear B023
...
B023 Function definition does not bind loop variable 'already_selected_buckets_value_sum'
in keepkey/qt.py, looks like this was an actual bug
(fixed in trezor plugin already: 52a4810752 )
3 years ago
SomberNight
612d3493df
fix flake8-bugbear B017
...
B017 `assertRaises(Exception)` and `pytest.raises(Exception)` should be considered evil. They can lead to your test passing even if the code being tested is never executed due to a typo. Assert for a more specific exception (builtin or custom), or use `assertRaisesRegex` (if using `assertRaises`), or add the `match` keyword argument (if using `pytest.raises`), or use the context manager form with a target.
3 years ago
SomberNight
90315e72d6
fix flake8-bugbear B016
...
B016 Cannot raise a literal. Did you intend to return it or raise an Exception?
3 years ago
SomberNight
8266ebcc46
fix flake8-bugbear B008
...
B008 Do not perform function calls in argument defaults. The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call. If this is intended, assign the function call to a module-level variable and use that variable as a default value.
3 years ago
SomberNight
e2406f21b4
fix flake8-bugbear B011
...
B011 Do not call assert False since python -O removes these calls. Instead callers should raise AssertionError().
3 years ago
SomberNight
312f2641e7
don't use bare except
...
use "except Exception", or if really needed explicitly "except BaseException"
3 years ago
Sander van Grieken
6848b8f375
qml: refactor all custom QRScan component wrappers to ScanDialog
...
(except SendDialog, which has a Paste button and slightly different behavior)
3 years ago
Sander van Grieken
49df18c613
qml: add hint property to QRScan
3 years ago
Sander van Grieken
959d481e93
qml: create ScanDialog
3 years ago
Sander van Grieken
674c2b55e7
qml: small fixes
3 years ago
Sander van Grieken
2fc9ee5c51
p4a: fix for Qt5 accessibility bug
...
see 087fc3c583
3 years ago
SomberNight
b429992e77
wizard.py: don't use mutable default args
3 years ago
SomberNight
e9aad6896e
wizard.py: change stack to be per-instance
...
seems less error-prone
3 years ago
SomberNight
fd9a90f3b6
wizard.py: fix clearing stack between wizards
...
try finishing a wizard and then launching a new one: the new one kept
building on top of the stack of the prev wizard
3 years ago
SomberNight
417423ecd7
qt: PayToEdit: fix input_qr_from_camera
...
closes https://github.com/spesmilo/electrum/issues/8342
probably regression from 1f4cedf56a
3 years ago
SomberNight
a8623f63bb
qml: fix send "flow with LN but not LN enabled AND having bip21 uri"
...
closes https://github.com/spesmilo/electrum/issues/8334
3 years ago
SomberNight
7907eb1f86
qml/qeinvoice.py: turn _bip21 field into local var
3 years ago
SomberNight
6b75d5f134
qt SwapDialog: handle sm.max_amount_forward_swap() being None
...
closes https://github.com/spesmilo/electrum/issues/8341
3 years ago
SomberNight
ea864cd5c9
qml: TxListModel: don't rely on wallet.db.get_transaction() finding tx
...
tx might get removed from wallet after wallet.get_full_history() but before the model is populated
closes https://github.com/spesmilo/electrum/issues/8339
3 years ago
SomberNight
1a2d4494eb
qt: fix sweeping
...
closes https://github.com/spesmilo/electrum/issues/8340
regression from 2f6d60c715
3 years ago
SomberNight
ad58916729
wizard.py: (trivial) fix type hint and an f-string
3 years ago
SomberNight
6b0db411ae
wallet: save_db immediately after init_lightning() generates keys
...
Had a crash shortly after enabling lightning and the LN keys were lost...
Though note that opening a channel triggers wallet.save_db(), so I think
nothing of real value is at risk without this change.
3 years ago
ThomasV
0fcf423fbe
Revert "lnworker: schedule_force_closing is not async"
...
This reverts commit fcf836bc94 .
3 years ago
ThomasV
fcf836bc94
lnworker: schedule_force_closing is not async
3 years ago
ThomasV
f787d6eede
qt piechart: show a full circle if there is only one item in the list
3 years ago
Sander van Grieken
0d536b83ba
qml: ignore update() when wallet not set yet. closes #8330
3 years ago
Sander van Grieken
7383cdc474
qml: don't crash when tx not found on histogram event. closes #8332
3 years ago
SomberNight
75a9a4fce9
qml TxDetails: txid must be updated after rawtx is changed
...
refresh bug when using bump_fee/dscancel/etc
3 years ago
SomberNight
2ec4758a12
qml: follow-up fix for offline-signing pre-segwit tx
...
follow-up 3cec6cdcfb
3 years ago
SomberNight
2be71c2dcc
windows README: update reference to libsecp256k1-0.dll to incl newer
...
related: https://github.com/spesmilo/electrum/pull/8185
3 years ago
SomberNight
ca3f48d22e
qml: remove buggy "Replace-by-Fee" checkbox from RbfCancelDialog
...
follow-up 02dce339cc
3 years ago
Sander van Grieken
e9d5e5737e
qml: update UI after import key/address, add icon to address/key import dialog
3 years ago
Sander van Grieken
c3a418d4da
qml: address list heading translatable
3 years ago
SomberNight
cede16a522
libsecp256k1: update hardcoded .so lib name in binaries
...
follow-up 2a2b683d23
TODO: maybe we should drop the version number in the lib name we bundle...
3 years ago
Sander van Grieken
2f8ab8027b
qml: split off AddressDelegate and handle imported addresses more gracefully
3 years ago
SomberNight
ae8501e5be
qml: small fix in qetxfinalizer.py
...
follow-up 3cec6cdcfb
3 years ago
Sander van Grieken
bd897b0955
qml: translate <no label>
3 years ago
SomberNight
2a2b683d23
bump libsecp256k1 version
3 years ago
SomberNight
784fc27cb9
libsecp256k1: add runtime support for 0.3.x
...
this replaces https://github.com/spesmilo/electrum/pull/8320
see f6bef03c0a/CHANGELOG.md
I am not yet sure how this will look like going forward, but unless there will
be lots of libsecp256k1 releases with ~invisible harmless ABI changes, I think
conceptually this is the right approach.
3 years ago
Sander van Grieken
3cec6cdcfb
qml: second part of partially signing tx while not having txid yet
3 years ago
Sander van Grieken
03d9000e79
qml: fix a few texts that should wrap
3 years ago
Sander van Grieken
b9ec04f13a
qml: make txdetails less reliant on txid
3 years ago
SomberNight
75e65c5cc7
qml: virtual keyboard: make margins smaller, for larger buttons
...
Looking at different system-wide keyboards on different phones, these
new smaller margin sizes should still be sufficient; and this lets
the buttons be larger.
3 years ago
Sander van Grieken
1aa14e749a
qml: first part of partially signing tx while not having txid yet
3 years ago
SomberNight
1b5c7d46d7
lnurl: forbid paying to "http://" lnurls (enforce https or .onion)
...
In theory merchants should only use safeish non-mitm-able schemes, but
let's add this sanity check for peace of mind.
3 years ago
SomberNight
8f576e50a4
lnurl: add some error-handling/response-validation
3 years ago
SomberNight
be159b5b95
bugfix: assert walrus (":=") combo side-eff. breaks w/ asserts disabled
...
```
$ python3 -O
Python 3.10.6 (main, Mar 10 2023, 10:55:28) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> assert (x := 2)
>>> x
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
NameError: name 'x' is not defined
```
pity. it looked to be a neat and concise pattern.
3 years ago