electrum

Author	SHA1	Message	Date
SomberNight	9743bd5219	pyinstaller build: (trivial) format so that win/osx look more similar	2 years ago
SomberNight	b551cb5f75	pyinstaller build: better parameterise .spec	2 years ago
SomberNight	0912e5615d	pyinstaller build: follow-up: dirty hack for duplicate plugins Ah ok, I give up for now... the prev does not really work. The prior commit works on Windows but not on macOS. On Windows, it would package all plugins as code and only as code. On MacOS however, it would not package any plugins at all. And with this commit, where I mark the plugins folder to be packaged as data, it packages all plugins as both code and data. Not sure why. Let's just package all plugins as both code and data, and ignore the code instances explicitly...	2 years ago
SomberNight	4cc9ef2078	pyinstaller build: clean-up .spec, fix issue described in prev commit The hw_wallet and jade plugins were being included twice in the pyinstaller binaries. They were apparently the only two plugins being picked as "modules" (a.pure), which by default are included as compiled-bytecode. In addition, we included "electrum/plugins" as data (a.data), which meant all plugins in source form. Instead of hacking around to fix the specific issue, this attempts a larger clean-up.	2 years ago
SomberNight	b5f1783a62	plugins: better error and logging on duplicate plugins (=plugin name collision) This assert is currently failing in pyinstaller builds (probably have been since it was added in `552bfb589a`). Looks like the pyinstaller binaries include two copies of the hw_wallet and the jade plugins. This likely has been the case for years, we just never noticed. -- but it started triggering the new assert. ``` 2.78 \| I \| plugin \| iter_modules=[ ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='audio_modem', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='bitbox02', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='coldcard', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='cosigner_pool', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='digitalbitbox', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='hw_wallet', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='jade', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='keepkey', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='labels', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='ledger', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='payserver', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='revealer', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='safe_t', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='swapserver', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='trezor', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='trustedcoin', ispkg=True), ModuleInfo(module_finder=FileFinder('C:\\Program Files (x86)\\Electrum\\electrum\\plugins'), name='virtualkeyboard', ispkg=True), ModuleInfo(module_finder=<pyimod02_importers.FrozenImporter object at 0x015FDFB8>, name='hw_wallet', ispkg=True), ModuleInfo(module_finder=<pyimod02_importers.FrozenImporter object at 0x015FDFB8>, name='jade', ispkg=True)] ```	2 years ago
SomberNight	2c3c50a09b	mac build: fix pyinstaller erroring due to not being able to import pyqt6 Not sure why this a problem in the mac build but not in the windows build... Also not sure why this only came up now -- was working before. (I changed a few things in prev commits re the build scripts but I can't see the cause) ``` 34827 INFO: Processing module hooks... 34828 INFO: Loading module hook 'hook-cryptography.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/_pyinstaller_hooks_contrib/hooks/stdhooks'... 35932 INFO: Loading module hook 'hook-mnemonic.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/_pyinstaller_hooks_contrib/hooks/stdhooks'... 35937 INFO: Loading module hook 'hook-certifi.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/_pyinstaller_hooks_contrib/hooks/stdhooks'... 35939 INFO: Loading module hook 'hook-dns.rdata.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/_pyinstaller_hooks_contrib/hooks/stdhooks'... 36502 INFO: Loading module hook 'hook-usb1.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/usb1/__pyinstaller'... 36503 INFO: --- libusb1 pyinstaller hook --- 36504 INFO: Added libusb binaries: [] 36505 INFO: Loading module hook 'hook-sqlite3.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 36932 INFO: Loading module hook 'hook-pkg_resources.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 38303 INFO: Loading module hook 'hook-PyQt5.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 38584 WARNING: Hidden import "sip" not found! 38586 INFO: Loading module hook 'hook-xml.etree.cElementTree.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 38587 INFO: Loading module hook 'hook-lib2to3.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 38678 INFO: Loading module hook 'hook-_tkinter.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 39005 INFO: checking Tree 39006 INFO: Building Tree because Tree-00.toc is non existent 39006 INFO: Building Tree Tree-00.toc 39021 INFO: checking Tree 39022 INFO: Building Tree because Tree-01.toc is non existent 39022 INFO: Building Tree Tree-01.toc 39157 INFO: checking Tree 39158 INFO: Building Tree because Tree-02.toc is non existent 39158 INFO: Building Tree Tree-02.toc 39165 INFO: Loading module hook 'hook-encodings.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 39568 INFO: Loading module hook 'hook-distutils.util.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 39586 INFO: Loading module hook 'hook-platform.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 39587 INFO: Loading module hook 'hook-PyQt5.QtGui.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 39734 INFO: Loading module hook 'hook-PyQt5.QtPrintSupport.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 39984 INFO: Loading module hook 'hook-PyQt5.QtMultimedia.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40164 INFO: Loading module hook 'hook-packaging.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40165 INFO: Loading module hook 'hook-pickle.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40187 INFO: Loading module hook 'hook-heapq.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40192 INFO: Loading module hook 'hook-difflib.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40196 INFO: Loading module hook 'hook-PyQt5.QtWidgets.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40361 INFO: Loading module hook 'hook-multiprocessing.util.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40382 INFO: Loading module hook 'hook-sysconfig.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40421 INFO: Loading module hook 'hook-PyQt5.QtNetwork.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40545 INFO: Loading module hook 'hook-xml.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40691 INFO: Loading module hook 'hook-distutils.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40692 INFO: Loading module hook 'hook-PyQt5.QtCore.py' from '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks'... 40903 INFO: Looking for ctypes DLLs 40987 WARNING: Library Cfgmgr32 required via ctypes not found 40992 WARNING: Library setupapi required via ctypes not found 40994 WARNING: Library Advapi32 required via ctypes not found 40996 WARNING: Ignoring /System/Library/Frameworks/IOKit.framework/IOKit imported from /Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/serial/tools/list_ports_osx.py - only basenames are supported with ctypes imports! 40996 WARNING: Ignoring /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation imported from /Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/serial/tools/list_ports_osx.py - only basenames are supported with ctypes imports! 41028 INFO: Analyzing run-time hooks ... 41041 INFO: Including run-time hook '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks/rthooks/pyi_rth_pyqt5.py' 41043 INFO: Including run-time hook '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks/rthooks/pyi_rth_pkgutil.py' 41047 INFO: Including run-time hook '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks/rthooks/pyi_rth_inspect.py' 41049 INFO: Including run-time hook '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks/rthooks/pyi_rth_subprocess.py' 41051 INFO: Including run-time hook '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks/rthooks/pyi_rth_multiprocessing.py' 41055 INFO: Including run-time hook '/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/hooks/rthooks/pyi_rth_pkgres.py' 41140 INFO: Looking for dynamic libraries 719 INFO: gettext setting initial language to None Traceback (most recent call last): File "/Users/vagrant/electrum/contrib/osx/build-venv/bin/pyinstaller", line 8, in <module> sys.exit(run()) File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/__main__.py", line 178, in run run_build(pyi_config, spec_file, vars(args)) File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/__main__.py", line 59, in run_build PyInstaller.building.build_main.main(pyi_config, spec_file, kwargs) File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/building/build_main.py", line 934, in main build(specfile, distpath, workpath, clean_build) File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/building/build_main.py", line 856, in build exec(code, spec_namespace) File "contrib/osx/osx.spec", line 48, in <module> a = Analysis([electrum+ MAIN_SCRIPT, File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/building/build_main.py", line 381, in __init__ self.__postinit__() File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/building/datastruct.py", line 173, in __postinit__ self.assemble() File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/building/build_main.py", line 660, in assemble isolated.call(find_binary_dependencies, list(self.binaries), self.binding_redirects, collected_packages) File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/isolated/_parent.py", line 238, in call return isolated.call(function, args, kwargs) File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/isolated/_parent.py", line 176, in call raise RuntimeError(f"Child process call to {function.__name__}() failed with:\n" + output) RuntimeError: Child process call to find_binary_dependencies() failed with: File "/Users/vagrant/electrum/electrum/gui/qml/__init__.py", line 8, in <module> import PyQt6 ModuleNotFoundError: No module named 'PyQt6' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/isolated/_child.py", line 63, in run_next_command output = function(args, **kwargs) File "/Users/vagrant/electrum/contrib/osx/build-venv/lib/python3.10/site-packages/PyInstaller/building/build_main.py", line 157, in find_binary_dependencies __import__(package) File "/Users/vagrant/electrum/electrum/gui/qml/__init__.py", line 10, in <module> sys.exit("Error: Could not import PyQt6. On Linux systems, you may try 'sudo apt-get install python3-pyqt6'") SystemExit: Error: Could not import PyQt6. On Linux systems, you may try 'sudo apt-get install python3-pyqt6' 🗯 ERROR: Could not build binary ```	2 years ago
SomberNight	1451ec936a	win/mac build: fix pyinstaller missing libsecp during part of Analysis ``` 602 WARNING: Failed to collect submodules for 'pkg_resources._vendor.pyparsing.diagram' because importing 'pkg_resources._vendor.pyparsing.diagram' raised: ModuleNotFoundError: No module named 'railroad' libsecp256k1 library failed to load. exceptions: [FileNotFoundError("Could not find module 'C:\\python3\\lib\\site-packages\\electrum\\libsecp256k1-2.dll' (or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'C:\\python3\\lib\\site-packages\\electrum\\libsecp256k1-1.dll'(or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'C:\\python3\\lib\\site-packages\\electrum\\libsecp256k1-0.dll' (or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'libsecp256k1-2.dll' (or one ofits dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'libsecp256k1-1.dll' (or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'libsecp256k1-0.dll' (or one of its dependencies). Try using the full path with constructor syntax.")] libsecp256k1 library failed to load. exceptions: [FileNotFoundError("Could not find module 'C:\\python3\\lib\\site-packages\\electrum\\libsecp256k1-2.dll' (or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'C:\\python3\\lib\\site-packages\\electrum\\libsecp256k1-1.dll'(or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'C:\\python3\\lib\\site-packages\\electrum\\libsecp256k1-0.dll' (or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'libsecp256k1-2.dll' (or one ofits dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'libsecp256k1-1.dll' (or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'libsecp256k1-0.dll' (or one of its dependencies). Try using the full path with constructor syntax.")] libsecp256k1 library failed to load. exceptions: [FileNotFoundError("Could not find module 'C:\\python3\\lib\\site-packages\\electrum\\libsecp256k1-2.dll' (or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'C:\\python3\\lib\\site-packages\\electrum\\libsecp256k1-1.dll'(or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'C:\\python3\\lib\\site-packages\\electrum\\libsecp256k1-0.dll' (or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'libsecp256k1-2.dll' (or one ofits dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'libsecp256k1-1.dll' (or one of its dependencies). Try using the full path with constructor syntax."), FileNotFoundError("Could not find module 'libsecp256k1-0.dll' (or one of its dependencies). Try using the full path with constructor syntax.")] 5921 WARNING: collect_data_files - skipping data collection for module 'electrum.plugins' as it is not a package. ```	2 years ago
SomberNight	262c009c67	pyinstaller build: towards fixing missing "gui/common_qt" folder pyinstaller tries to import electrum and its different submodules at build-time during the "Analysis" phase. sys._GUI_QT_VERSION was not getting set there, and the resulting exception was blocking pyinstaller from discovering that gui/common_qt is being used. at runtime: ``` $ ./dist/Electrum.app/Contents/MacOS/run_electrum 1.53 \| E \| daemon.Daemon \| GUI raised exception: Exception('Error loading trustedcoin plugin: ModuleNotFoundError("No module named \'electrum.gui.common_qt\'")'). shutting down. 1.53 \| E \| __main__ \| daemon.run_gui errored Traceback (most recent call last): File "electrum/plugin.py", line 135, in load_plugin spec.loader.exec_module(module) File "<frozen importlib._bootstrap_external>", line 883, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "/Users/vagrant/electrum/dist/Electrum.app/Contents/MacOS/electrum/plugins/trustedcoin/qt.py", line 51, in <module> from .common_qt import TrustedcoinPluginQObject File "/Users/vagrant/electrum/dist/Electrum.app/Contents/MacOS/electrum/plugins/trustedcoin/common_qt.py", line 16, in <module> from electrum.gui.common_qt.plugins import PluginQObject ModuleNotFoundError: No module named 'electrum.gui.common_qt' The above exception was the direct cause of the following exception: Traceback (most recent call last): File "run_electrum", line 456, in handle_cmd d.run_gui() File "electrum/daemon.py", line 617, in run_gui self.gui_object = gui.ElectrumGui(config=self.config, daemon=self, plugins=self._plugins) File "electrum/util.py", line 473, in do_profile o = func(args, *kw_args) File "electrum/gui/qt/__init__.py", line 153, in __init__ self.plugins.load_plugin('trustedcoin') File "electrum/plugin.py", line 138, in load_plugin raise Exception(f"Error loading {name} plugin: {repr(e)}") from e Exception: Error loading trustedcoin plugin: ModuleNotFoundError("No module named 'electrum.gui.common_qt'") ```	2 years ago
SomberNight	6467db0b7d	json_db: rename "_write" to sth more descriptive	2 years ago
Sander van Grieken	ae9767880e	ui: add icons for script type and deterministic wallet	2 years ago
ThomasV	85f13cc6ea	load_keystore: deepcopy object so that it differs from the one in db.data db.data should not be modified directly	2 years ago
Sander van Grieken	6efd1fc768	followup prev	2 years ago
Sander van Grieken	c16b83f46a	tests: add test verifying if privkey add to existing imported wallet persists correctly.	2 years ago
SomberNight	ff53925811	qt console: fix tracebacks in windows binaries fixes https://github.com/spesmilo/electrum/issues/3315 The cause was that tracebacks look different whether stack items have source text available. When using the pyinstaller windows binary, there is no source text available. Example when running from source: ``` >>> a Traceback (most recent call last): File "...\electrum\gui\qt\console.py", line 256, in exec_command result = eval(command, self.namespace, self.namespace) File "<string>", line 1, in <module> NameError: name 'a' is not defined ``` Example for pyinstaller windows binary: ``` >>> a Traceback (most recent call last): File "electrum\gui\qt\console.py", line 256, in exec_command File "<string>", line 1, in <module> NameError: name 'a' is not defined ```	2 years ago
SomberNight	b18f9570fc	qml wizard: fix creating imported wallet from camera: concat with space The parser expects the list of keys/addrs to be whitespace-separated (no commas). Same as line 61.	2 years ago
SomberNight	affe3630b0	qt: addr/coins tab: show tooltip for "freeze address" related https://github.com/spesmilo/electrum/issues/8698	2 years ago
Sander van Grieken	ab9c3bb9b4	qt: avoid potential proxy settings deserialization problems (fixes #8652 )	2 years ago
Sander van Grieken	6f9e86a1ac	qml: fix wrong year near newyear in transaction list	2 years ago
ThomasV	f602b2bbed	Merge pull request #8700 from SomberNight/202311_apk_build android build: we always want apks, as we want to use our own privkey	2 years ago
SomberNight	f14e99139c	android build: we always want apks, as we want to use our own privkey ThomasV reported contrib/release.sh generating .aab artifacts. aabs are shady business... best to avoid handing privkeys to big G (or any 3rd party!). This must be a consequence of the recent p4a rebase, e.g. `04bb63bbf0`	2 years ago
SomberNight	8db68cadcd	swaps: forward swap: make cltv requirements explicit related: `fb4eb86e7c`	2 years ago
SomberNight	9f1b8613d0	swaps: code style clean-up, add type hints, force kwargs no intended functional changes	2 years ago
SomberNight	9d5d582752	swaps: forward swap: (fix) propagate channels parameter	2 years ago
SomberNight	7f64ecc4bd	wallet.bump_fee: the glorious return of BumpFeeStrategy :D gui/qt/rbf_dialog.py (old) lines 57-64 were implementing logic that should not be part of GUI code. Case in point, gui/qml/qetxfinalizer.py (old) lines 511-513 duplicated half of that logic but not the other half. That logic is now moved to wallet.get_bumpfee_strategies_for_tx(). More context: a user on irc got confused when using the qml gui. They were sending "max" and wanted to bump_fee. The qml gui selected the "preserve_payment" strategy by default, using which there was no solution, and the user did not notice that the strategy can be altered (via the "method" dropdown). The qt gui had logic to select "decrease_payment" by default in such a case (which does find a solution to bump) but this logic was not duplicated in the qml gui. Instead of duplicating the logic, this commit moves it to shared lib code.	2 years ago
Sander van Grieken	03dd38bfb8	qml: add support for ln address and openalias, fix lnurl finalize step, avoid overloading invoiceParser with new payment identifiers while potentially long-running resolve/finalize steps are ongoing, show errors inresolve/finalize steps to user.	2 years ago
Sander van Grieken	ff77013a82	qml: check if self._orig_tx is valid. fixes #8407	2 years ago
Sander van Grieken	b098be988e	qml: show channel close tx(id) in ChannelDetails	2 years ago
SomberNight	6a8fb26881	(trivial) follow-up prev	2 years ago
SomberNight	4cdd199f5b	lnworker: add/fix some type hints, add some comments follow-up recent refactor	2 years ago
ThomasV	1cc92d4890	trampoline forwarding: before failing payment, wait until all htcs have failed and session is not longer active.	2 years ago
ThomasV	9b1c40e396	Refactor payment forwarding: - all forwarding types use the same flow - forwarding callback returns a htlc_key or None - forwarding info is persisted in lnworker: - ongoing_forwardings - downstream to upstream htlc_key - htlc_key -> error_bytes	2 years ago
SomberNight	f1c63e2d51	commands: make payto/etc respect 'confirmed_only' config var regression from `2f6d60c715` fixes https://github.com/spesmilo/electrum/issues/8693	2 years ago
SomberNight	c4068ab6cc	swaps: add small comment	2 years ago
ThomasV	835992c7ea	lnworker: remove if statements where the condition is always True. Such statements creates confusion for the reader.	2 years ago
Sander van Grieken	a57a0d001b	qml: make TextAreas more visible	2 years ago
Sander van Grieken	f8eb2e8cf8	qml: resize menus according to content	2 years ago
Sander van Grieken	4ab973f93d	followup `3793a6b6b6`, remove leftovers	2 years ago
Sander van Grieken	3793a6b6b6	qml: use highlight pane for QR codes, refactor ReceiveDialog invoice select UI.	2 years ago
Sander van Grieken	86a45c668c	few small fixes	2 years ago
Sander van Grieken	621a397b70	i18n: translate a few untranslated strings and avoid early translate for pr_tooltips and pr_expiration_values fixes #8689	2 years ago
SomberNight	4006a2f548	SECURITY.md: small clean-up	2 years ago
SomberNight	6ffaf7c526	lnworker: (followup prev) set .config in baseclass init, not subclasses as methods in the base class also rely on the config field, not just methods in the subclasses	2 years ago
ThomasV	7447cf9dcc	lnworker: always initialize self.config in constructor	2 years ago
ThomasV	6865204d7b	Merge pull request #8671 from spesmilo/just_in_time_channels Just in time channels	2 years ago
SomberNight	e5fae1d685	util.NetworkRetryManager: better document API	2 years ago
Sander van Grieken	94b1df4a08	qml: small UI fix, wording.	2 years ago
ThomasV	7bebd62f13	zerofonf trusdted node: use NetworkRetryManager method _can_retry_addr	2 years ago
ThomasV	a338459d45	just-in-time channels: - a node scid alias is derived from the node ID - the channel opening fee is sent in a TLV field of open_channel - the server requires htlc settlement before broadcasting (server does not trust client)	2 years ago
ThomasV	816e617aaf	option_zeroconf - accept zeroconf channels only from a single node - fw_info uses get_scid_or_local_alias	2 years ago
ThomasV	96e143b6c3	lnpeer: abort send_revoke_and_ack and maybe_send_commitment if channel is closed. fixes #8684	2 years ago

1 2 3 4 5 ...

17087 Commits (9743bd5219d89a8eb86aa9dcb58bc692f4e3ab6c) All Branches Search

17087 Commits (9743bd5219d89a8eb86aa9dcb58bc692f4e3ab6c)

All Branches