SomberNight
1b5c7d46d7
lnurl: forbid paying to "http://" lnurls (enforce https or .onion)
...
In theory merchants should only use safeish non-mitm-able schemes, but
let's add this sanity check for peace of mind.
3 years ago
SomberNight
8f576e50a4
lnurl: add some error-handling/response-validation
3 years ago
SomberNight
be159b5b95
bugfix: assert walrus (":=") combo side-eff. breaks w/ asserts disabled
...
```
$ python3 -O
Python 3.10.6 (main, Mar 10 2023, 10:55:28) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> assert (x := 2)
>>> x
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
NameError: name 'x' is not defined
```
pity. it looked to be a neat and concise pattern.
3 years ago
SomberNight
22205dccb1
qt ChannelsList: disable toolbar menu if `not wallet.has_lightning()`
...
closes https://github.com/spesmilo/electrum/issues/8321
3 years ago
SomberNight
fa04ff005b
contrib: fix build_locale.sh to work with relative paths
...
I think all scripts that call this file already used abs paths,
but manual callers tend to use relative paths.
3 years ago
SomberNight
b0b4f39b40
i18n: add "context" param to _(), and use it from qml
...
fixes https://github.com/spesmilo/electrum/issues/8323
from issue:
> Currently, translatable strings from QML are assigned a `context`
> by `lupdate`, which is then also used by the conversion to `gettext`.
> This `context` must be used when translating such a string. This results in
> strings that are unique to QML to not be translated, due to a missing
> `context` parameter which we do not take into account in electrum.
3 years ago
Sander van Grieken
1a4e48e2d4
qml: fix MessageDialog layout
3 years ago
Sander van Grieken
54ab3673ba
qml: TxDetails don't show or allow edit of label for unrelated tx
3 years ago
Sander van Grieken
3b7fa89e44
wizard: p2sh multisig is 'standard' in backend wallet
3 years ago
Sander van Grieken
323aa84279
qml: only allow wallet menu if on wallet specific page
3 years ago
Sander van Grieken
1649f9993e
qml: limit wallet name label widths so they get wrapped/elided. fixes #8317
3 years ago
Emanuel Haupt
fd6e34bf5f
fix: Fix libsecp256k1 loader on FreeBSD
...
FreeBSD installs libsecp256k1 as:
```
/usr/local/lib/libsecp256k1.so.2.0.1
/usr/local/lib/libsecp256k1.so -> libsecp256k1.so.2.0.1
/usr/local/lib/libsecp256k1.so.2 -> libsecp256k1.so.2.0.1
```
3 years ago
SomberNight
a2063f8f48
qt tx dialog: rm dead code
3 years ago
SomberNight
42ec0e4e9d
slip39: fix incorrect type hint
3 years ago
SomberNight
cbb4c3ceb2
slip39: rewrite some strings for better localisation
...
related: https://github.com/spesmilo/electrum/issues/8314
3 years ago
SomberNight
dd93ebda4d
wallet: _bump_fee_through_decreasing_payment: handle too high fee_rate
...
fixes https://github.com/spesmilo/electrum/issues/8316
3 years ago
Sander van Grieken
7b475f58db
qml: show unrelated tx also in top InfoTextArea
3 years ago
SomberNight
89b75f95d0
wallet.set_broadcasting: fix incorrect type-hint and rename arg
3 years ago
SomberNight
e24f837fbf
qt send tab: rm incorrect bare raise
...
follow-up bc3946d2f4
not sure what the raise was trying to do;
note that relevant exception handling is done at:
bba8a272e7/electrum/gui/qt/main_window.py (L1213-L1217)
although note the TODO in main_window.on_error: would be nice to propagate some of the exceptions to the crash reporter
closes https://github.com/spesmilo/electrum/issues/8312
3 years ago
SomberNight
bba8a272e7
qt send tab: rm unused variable and add explanation
3 years ago
SomberNight
e617dd07a0
qt send tab: fix payto_contacts
...
closes https://github.com/spesmilo/electrum/issues/8313
3 years ago
ghost43
75578d2baa
Merge pull request #8310 from SomberNight/202304_build_debian_apt_rm_contrib
...
build: rm "contrib" from debian apt sources lists
3 years ago
l-pt
f15abd7cbd
remove PATH manipulation from .desktop file ( #8309 )
...
* remove PATH manipulation from .desktop file
* Add note for user-local intallations
3 years ago
SomberNight
16fcfe34a7
build: rm "contrib" from debian apt sources lists
3 years ago
ThomasV
36db6673a5
update release notes for version 4.4.0
3 years ago
Victor Forgeoux
ee61f99c22
Add support for Ledger Stax ( #8308 )
...
* Add support for Ledger Stax
3 years ago
ThomasV
be2f156a4b
qml swaphelper: show errors in userinfo
3 years ago
SomberNight
ca40b37ec5
qml: show "tx fee rate" in TxDetails, like in other guis
3 years ago
Sander van Grieken
43b3e07479
Revert "qml: don't determine channel state on gui string, use state enum instead"
...
This reverts commit 73f89d516a .
3 years ago
Sander van Grieken
6733665dac
qml: simplify path_protect decorator
3 years ago
ThomasV
9dbf354bf2
follow-up a03f4769ca
...
fixes TypeError: auth_protect.<locals>.decorator() got an unexpected keyword argument 'broadcast'
3 years ago
ThomasV
5e29b94561
qml MessageDialog: split messages into title and header message. hide header if it is empty.
3 years ago
Sander van Grieken
bea41d2098
release notes (qml)
3 years ago
Sander van Grieken
f68d91e988
update release notes (qml)
3 years ago
ThomasV
03d64aa665
qt: use same icon as qml for swap dialog
3 years ago
ThomasV
9b98d762ee
update locale submodule
3 years ago
ThomasV
6bdda957c0
qml: reformulate swap success message
3 years ago
ThomasV
f513ba4654
messageDialog: change title to Question for yesno dialogs
3 years ago
ThomasV
86aca1e24e
qml: change title of ConfirmTxDialog
...
From a user perspectuve, what they are asked to do is select the mining fee.
3 years ago
ThomasV
dde609872d
follow-up a03f4769ca
...
It is annoying that this kind of bug (missing parameter) is silent.
3 years ago
SomberNight
a6c36b8588
regtests: test_watchtower started failing due to newly exposed bug
...
local_watchtower.adb.start_network was getting called twice.
follow-up 6ac3f84095
```
20230418T014725.636141Z | ERROR | __main__ |
Traceback (most recent call last):
File "/home/user/wspace/electrum/./run_electrum", line 435, in main
handle_cmd(
File "/home/user/wspace/electrum/./run_electrum", line 469, in handle_cmd
d = daemon.Daemon(config, fd)
File "/home/user/wspace/electrum/electrum/util.py", line 462, in <lambda>
return lambda *args, **kw_args: do_profile(args, kw_args)
File "/home/user/wspace/electrum/electrum/util.py", line 458, in do_profile
o = func(*args, **kw_args)
File "/home/user/wspace/electrum/electrum/daemon.py", line 404, in __init__
self.network = Network(config, daemon=self)
File "/home/user/wspace/electrum/electrum/network.py", line 348, in __init__
self.local_watchtower.adb.start_network(self)
File "/home/user/wspace/electrum/electrum/address_synchronizer.py", line 185, in start_network
assert self.network is None, "already started"
AssertionError: already started
```
3 years ago
SomberNight
5c83327eb0
qml: small change to some qsTr() strings to reuse existing translations
...
not all ":" suffixes are removed, only the ones where this allows reusing translations
3 years ago
SomberNight
27ce8ba241
i18n: log initial default language set based on OS locale
3 years ago
SomberNight
e3544f260b
i18n: log set_language
3 years ago
ThomasV
b42bb84b5c
fix typo
3 years ago
SomberNight
6ac3f84095
wallet/lnworker/etc: add sanity checks to start_network methods
...
related: https://github.com/spesmilo/electrum/issues/8301
3 years ago
ThomasV
a03f4769ca
auth_protect: pass authMessage in the auth_protect decorator,
...
instead of relying on side-effects
This is probably safer, and also more self-contained.
3 years ago
ThomasV
73dd6827e0
add auth_message to delete_wallet
...
This changes the flow slightly: pin confirmation is asked after
we have checked that the wallet does not have open channels,
which is better
3 years ago
ThomasV
1421df57ad
add auth message for open_channel
3 years ago
ThomasV
e430063351
PIN dialog: display auth message as title, if available
3 years ago