Browse Source

qml: remove yesClicked signal, use accept()/accepted signal in MessageDialog.

master
Sander van Grieken 3 years ago
parent
commit
75f63a4666
  1. 2
      electrum/gui/qml/components/ChannelDetails.qml
  2. 14
      electrum/gui/qml/components/MessageDialog.qml
  3. 2
      electrum/gui/qml/components/OpenChannelDialog.qml
  4. 2
      electrum/gui/qml/components/Preferences.qml
  5. 3
      electrum/gui/qml/components/TxDetails.qml
  6. 8
      electrum/gui/qml/components/WalletDetails.qml
  7. 2
      electrum/gui/qml/components/WalletMainView.qml
  8. 6
      electrum/gui/qml/components/main.qml

2
electrum/gui/qml/components/ChannelDetails.qml

@ -249,7 +249,7 @@ Pane {
: qsTr('Are you sure you want to delete this channel? This will purge associated transactions from your wallet history.'), : qsTr('Are you sure you want to delete this channel? This will purge associated transactions from your wallet history.'),
yesno: true yesno: true
}) })
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
channeldetails.deleteChannel() channeldetails.deleteChannel()
app.stack.pop() app.stack.pop()
Daemon.currentWallet.historyModel.init_model(true) // needed here? Daemon.currentWallet.historyModel.init_model(true) // needed here?

14
electrum/gui/qml/components/MessageDialog.qml

@ -16,8 +16,6 @@ ElDialog {
property alias text: message.text property alias text: message.text
property bool richText: false property bool richText: false
signal yesClicked
z: 1 // raise z so it also covers dialogs using overlay as parent z: 1 // raise z so it also covers dialogs using overlay as parent
anchors.centerIn: parent anchors.centerIn: parent
@ -49,7 +47,7 @@ ElDialog {
text: qsTr('Ok') text: qsTr('Ok')
icon.source: Qt.resolvedUrl('../../icons/confirmed.png') icon.source: Qt.resolvedUrl('../../icons/confirmed.png')
visible: !yesno visible: !yesno
onClicked: dialog.close() onClicked: accept()
} }
FlatButton { FlatButton {
@ -59,10 +57,7 @@ ElDialog {
text: qsTr('Yes') text: qsTr('Yes')
icon.source: Qt.resolvedUrl('../../icons/confirmed.png') icon.source: Qt.resolvedUrl('../../icons/confirmed.png')
visible: yesno visible: yesno
onClicked: { onClicked: accept()
yesClicked()
dialog.close()
}
} }
FlatButton { FlatButton {
Layout.fillWidth: true Layout.fillWidth: true
@ -71,10 +66,7 @@ ElDialog {
text: qsTr('No') text: qsTr('No')
icon.source: Qt.resolvedUrl('../../icons/closebutton.png') icon.source: Qt.resolvedUrl('../../icons/closebutton.png')
visible: yesno visible: yesno
onClicked: { onClicked: reject()
reject()
dialog.close()
}
} }
} }
} }

2
electrum/gui/qml/components/OpenChannelDialog.qml

@ -194,7 +194,7 @@ ElDialog {
onConflictingBackup: { onConflictingBackup: {
var dialog = app.messageDialog.createObject(app, { 'text': message, 'yesno': true }) var dialog = app.messageDialog.createObject(app, { 'text': message, 'yesno': true })
dialog.open() dialog.open()
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
channelopener.open_channel(true) channelopener.open_channel(true)
}) })
} }

2
electrum/gui/qml/components/Preferences.qml

@ -258,7 +258,7 @@ Pane {
text: qsTr('Using plain gossip mode is not recommended on mobile. Are you sure?'), text: qsTr('Using plain gossip mode is not recommended on mobile. Are you sure?'),
yesno: true yesno: true
}) })
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
Config.useGossip = true Config.useGossip = true
}) })
dialog.rejected.connect(function() { dialog.rejected.connect(function() {

3
electrum/gui/qml/components/TxDetails.qml

@ -400,8 +400,7 @@ Pane {
onLabelChanged: root.detailsChanged() onLabelChanged: root.detailsChanged()
onConfirmRemoveLocalTx: { onConfirmRemoveLocalTx: {
var dialog = app.messageDialog.createObject(app, { text: message, yesno: true }) var dialog = app.messageDialog.createObject(app, { text: message, yesno: true })
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
dialog.close()
txdetails.removeLocalTx(true) txdetails.removeLocalTx(true)
root.close() root.close()
}) })

8
electrum/gui/qml/components/WalletDetails.qml

@ -18,7 +18,7 @@ Pane {
function enableLightning() { function enableLightning() {
var dialog = app.messageDialog.createObject(rootItem, var dialog = app.messageDialog.createObject(rootItem,
{'text': qsTr('Enable Lightning for this wallet?'), 'yesno': true}) {'text': qsTr('Enable Lightning for this wallet?'), 'yesno': true})
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
Daemon.currentWallet.enableLightning() Daemon.currentWallet.enableLightning()
}) })
dialog.open() dialog.open()
@ -27,7 +27,7 @@ Pane {
function deleteWallet() { function deleteWallet() {
var dialog = app.messageDialog.createObject(rootItem, var dialog = app.messageDialog.createObject(rootItem,
{'text': qsTr('Really delete this wallet?'), 'yesno': true}) {'text': qsTr('Really delete this wallet?'), 'yesno': true})
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
Daemon.checkThenDeleteWallet(Daemon.currentWallet) Daemon.checkThenDeleteWallet(Daemon.currentWallet)
}) })
dialog.open() dialog.open()
@ -476,13 +476,13 @@ Pane {
function onWalletDeleteError(code, message) { function onWalletDeleteError(code, message) {
if (code == 'unpaid_requests') { if (code == 'unpaid_requests') {
var dialog = app.messageDialog.createObject(app, {text: message, yesno: true }) var dialog = app.messageDialog.createObject(app, {text: message, yesno: true })
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
Daemon.checkThenDeleteWallet(Daemon.currentWallet, true) Daemon.checkThenDeleteWallet(Daemon.currentWallet, true)
}) })
dialog.open() dialog.open()
} else if (code == 'balance') { } else if (code == 'balance') {
var dialog = app.messageDialog.createObject(app, {text: message, yesno: true }) var dialog = app.messageDialog.createObject(app, {text: message, yesno: true })
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
Daemon.checkThenDeleteWallet(Daemon.currentWallet, true, true) Daemon.checkThenDeleteWallet(Daemon.currentWallet, true, true)
}) })
dialog.open() dialog.open()

2
electrum/gui/qml/components/WalletMainView.qml

@ -372,7 +372,7 @@ Item {
text: qsTr('Import Channel backup?'), text: qsTr('Import Channel backup?'),
yesno: true yesno: true
}) })
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
Daemon.currentWallet.importChannelBackup(data) Daemon.currentWallet.importChannelBackup(data)
close() close()
}) })

6
electrum/gui/qml/components/main.qml

@ -382,8 +382,7 @@ ApplicationWindow
wallet: Daemon.currentWallet wallet: Daemon.currentWallet
onConfirm: { onConfirm: {
var dialog = app.messageDialog.createObject(app, {text: message, yesno: true}) var dialog = app.messageDialog.createObject(app, {text: message, yesno: true})
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
dialog.close()
__swaphelper.executeSwap(true) __swaphelper.executeSwap(true)
}) })
dialog.open() dialog.open()
@ -459,8 +458,7 @@ ApplicationWindow
text: qsTr('Close Electrum?'), text: qsTr('Close Electrum?'),
yesno: true yesno: true
}) })
dialog.yesClicked.connect(function() { dialog.accepted.connect(function() {
dialog.close()
app._wantClose = true app._wantClose = true
app.close() app.close()
}) })

Loading…
Cancel
Save