You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tree: f37e804d4e

add_frost

add_frost_channel_encryption

master

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from 'f37e804d4e'

${ noResults }

joinmarket-clientserver/jmclient

History

Kristaps Kaupe d563b3f28b Merge #511: Display INFO level log message on estimate_fee_per_kb() with result ... 16cf93ab82 Display INFO level log message on estimate_fee_per_kb() with result (Kristaps Kaupe) Pull request description: Today I accidentally did a tx with smaller fee than I wanted to, because I forgot that `joinmarket.cfg` is moved from `scripts/` to `~/.joinmarket/` in current master and looked in a wrong file for a current setting. This adds INFO log level message on every call to `estimate_fee_per_kb()`. Very likely with this change I would have noticed wrong tx fee setting before tx was negotiated and broadcast to the network. It displays both sat/vkB and sat/vB values, as first is kinda what JM uses internally, but second one might be the one most people are familiar with. As we are talking about the money here, I do believe it's better to display the same info two different ways than for people to do some mistake. Also additional minor changes to `jmbitcoin/jmbitcoin/amount.py` to make `pycodestyle` happy (our current code is far from that, but I don't see downside for at least to try to write the new code according to PEP 8 guidelines). Top commit has no ACKs. Tree-SHA512: 52385d711039bd9abb522298c39271a5cff9a21997f5b2434a87f278d583600f258ebff98f067373b329f337fd08e27f8b4a86d6297154bce109c319e50fd11e		6 years ago
..
jmclient	Merge #511: Display INFO level log message on estimate_fee_per_kb() with result	6 years ago
test	Merge #504: Remove Python 2 compatibility imports and disable Python 2 installation in setuptools.	6 years ago
setup.py	Remove Python 2 compatibility imports and disable Python 2 installation in setuptools.	6 years ago