You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tree: 500fbee439

add_frost

add_frost_channel_encryption

master

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from '500fbee439'

${ noResults }

joinmarket-clientserver/jmclient

History

Adam Gibson 52b9ba8573 Initialization of BCI raises Exception not sys.exit ... Reasoning for this change: to ensure that Qt will show a message and gracefully exit (or quit attempting to load a wallet) in all 3 cases: on startup it show an intelligible message if the RPC connection fails (as before this PR), if the RPC fails while no wallet is loaded and thus no wallet service is started, it should show an intelligible error message when you attempt to load a wallet and it fails, and finally it should show an intelligible error message before quitting, if the rpc connection fails during the period when the wallet is already loaded. By switching to an Exception instead of sys.exit, it does mean that starting a yieldgenerator shows a stack trace, but it also shows an intelligible error message (in red), and this is command line, so UI requirements are less strong. We preserve the "good" behaviour of no stack trace, but only error message, if the rpc connection is lost during running.		6 years ago
..
jmclient	Initialization of BCI raises Exception not sys.exit	6 years ago
test	Quit gracefully if Bitcoin RPC connection lost	6 years ago
setup.py	add release notes and version numbers for 0.6.2	6 years ago