Error message about missing matplotlib is only correct in case of
exception during `import matplotlib`. If there is fatal exception
later, it is some other issue and it's better display it as is. On a
RaspiBolt for me `import matplotlib.pyplot as plt` causes
"ImportError: libopenjp2.so.7: cannot open shared object file: No such file or directory".
5ca78c29ea install.sh now works on macOS, no need to follow more complicated guide (Kristaps Kaupe)
Pull request description:
Top commit has no ACKs.
Tree-SHA512: 1e28e8b6c907429e488cbb284fccb7934cd8be83b92bf18e09169feaf31ca0729e70cbd4894259505e87cffd34e55773abf46fa4229cbb47c5396f285f86c2cb
fd9d98fd09Fixes#639. Allow export of private keys in Qt. (Adam Gibson)
Pull request description:
Additionally, we add a note to wif_to_privkey()
in jmclient.cryptoenging.BTCEngine because the
'keytype' variable constructed there is not currently
usabe, and we remove a check of that keytype in
the add_utxo script used for PoDLE (it is not relevant).
ACKs for top commit:
kristapsk:
ACK fd9d98fd09
Tree-SHA512: 161c8cfab80b7eef04ce0f22253946530121e4827769096e80e3019529a6736c2a5525188ef04c695c8f0db704da144648732d5cea026667fbf4b047db973abd
Additionally, we add a note to wif_to_privkey()
in jmclient.cryptoenging.BTCEngine because the
'keytype' variable constructed there is not currently
usabe, and we remove a check of that keytype in
the add_utxo script used for PoDLE (it is not relevant).
In this commit, the jmclient.payjoin module now supports
sending payments to BIP21 URIs where the pj= parameter is
to a hidden service address.
Additionally, the test/payjoinclient and test/payjoinserver
modules are edited to support optionally testing payments to
an ephemeral hidden service.
73b0edc219 Update macOS installation instructions (Jules Comte)
Pull request description:
This should be merged after #536, and is a followup to #629
It includes build instructions for libsecp256k1 for those who don't use `install.sh`
@AdamISZ I was wrong, it turns out that `install.sh` does need some modifications to work on mac os from scratch.
My biggest question at this point is whether I have the list of darwin dependencies correct in `install.sh: line 44`
With the current list, I was able to build, and pass the testsuite on fresh installations of Mac OS Catalina with Apple Command Line Tools and Homebrew installed.
Top commit has no ACKs.
Tree-SHA512: f9feed9d6052cefd043a025212e27347669aa6a082a4543d2f19a64f74ceb51694fa33efb5a92b79f7fc15a70efead4ac32cee3ab78acb6badd894f8b616aede
Prior to this commit, the BIP78 payjoin would broadcast
a fallback transaction in case of the server returning an
error, but would not do so in case of server non-response.
After this commit, we add a 60 second timeout after which
the non-payjoin fallback is broadcast client side; see
BIP78 for an explanation of this behaviour.
e5ec172442 Output frozen UTXO's on showutxos too, add "frozen" state to output (Kristaps Kaupe)
Pull request description:
Top commit has no ACKs.
Tree-SHA512: 4bf23cce899918a054baacc6551e13df66d5ece4847e534aa7aa6b5e96473c5d65a2c5d2e0d5f66d0f7eb6d692f5674207a50f06bbfb071be52dfcb361c9b8fa
Kristaps Kaupe
Adam Gibson
Jules Comte
James Hilliard
jules23