In case Taker.initialize() fails for any reason such as no
liquidity, stallMonitor() will not wake up for 20*maker_timeout_sec;
so, in this change, IF the client schedule has length one, we
immediately figure the on_finished_callback with failure parameters
so that the reactor is stopped without waiting.
This change does not apply for the general multi-step schedule, as
that is principally for tumbler-style algos which are intended to
aggressively keep trying in case of any failure.
More on bug: when signing txs with SW and non-SW inputs, the
existing signature_form for non-SW inputs didnt pay attention
to whether the tx serialization was SW or non-SW style, so if
a SW-style tx serialization was passed in, it was kept in SW
form after passing through signature_form, resulting in an attempt
to create a signature based on SW style sighashing. The fix here
just ensures that signature_form always enforces the tx format
to be non-SW style, so allowing callers to sign() to get a valid
signature whatever they pass in.
On pressing Abort, the confirm_callback and clientStart calls
should not proceed, also startNextTransaction triggered from Qt
singleShot should be stop()ed. This is Qt specific as command
line does not involve restart within same app instance.
via 0 entry in num counterparties. Modify tooltip to reflect.
Rename tumble_support to taker_utils for generic Taker code.
Refactor direct_send function to that module, shared with
sendpayment CLI script.
Modify tooltip for Start button to explain Abort
Retrieve nonresponsive makers in daemon and pass to client
Taker receives ignored_makers in init and client adds
Adam Gibson
eduard6