Browse Source

Merge JoinMarket-Org/joinmarket-clientserver#1106: Do not auto generate the QT UI code in setup.py

f899daabe6 Do not auto generate the QT UI code in setup.py (Wukong)

Pull request description:

  If the user has an incompatible version of PySide2 installed on their system, the generation process might fail.

  Since we have already checked in the correct version of the generated QT UI code, we don't need to run the generation process for every user in the `setup.py`

  Hopefully this fixes #1087

Top commit has no ACKs.

Tree-SHA512: d1b5189369dfbdeda83250e9ebdd93d4bb14632ded5bd3a10a88362e237f548756326122755aa84a03ff74e558039adf288fc21c16a3d256486780d734edbb8f
master
Kristaps Kaupe 4 years ago
parent
commit
fbeab3ab32
No known key found for this signature in database
GPG Key ID: 33E472FE870C7E5D
  1. 5
      jmqtui/setup.py

5
jmqtui/setup.py

@ -13,4 +13,7 @@ setup(name='joinmarketui',
python_requires='>=3.6',
zip_safe=False)
os.system('pyside2-uic jmqtui/open_wallet_dialog.ui -o jmqtui/open_wallet_dialog.py')
# The following command should be executed whenever `open_wallet_dialog.ui` is updated.
# We have commented out this command so that we wouldn't require every user of JoinMarket-qt
# to install the correct version of pyside2-uic.
# os.system('pyside2-uic jmqtui/open_wallet_dialog.ui -o jmqtui/open_wallet_dialog.py')

Loading…
Cancel
Save