Merge #720: Make libsecp256k1 tests optional

aa3cec4623 Make libsecp256k1 tests optional (Kristaps Kaupe)

Pull request description:

  They are expensive and slow, especially on a slow hardware like
  Raspberry Pi.

  Inspired by https://github.com/bitcoin/bitcoin/pull/20264.

Top commit has no ACKs.

Tree-SHA512: ad23f8bab1f95fb5d0d7c6f2bcbe1a6950f7f62dd82e8d34d65abf6dffcfd1e7f9100d7c1423d1d8764ba6ce5145f5df17035130314432bb6e44361e7d773960

install.sh

@@ -241,8 +241,12 @@ libsecp256k1_build()
         --enable-benchmark=no \
         MAKE=$make
     $make
-    if ! $make check; then
+    if [[ $use_secp_check == '1' ]]; then
-        return 1
+        if ! $make check; then
+            return 1
+        fi
+    else
+        echo "Skipping libsecp256k1 tests."
     fi
 }
 
@@ -332,6 +336,9 @@ parse_flags ()
             --develop)
                 develop_build='1'
                 ;;
+            --disable-secp-check)
+                use_secp_check='0'
+                ;;
             -p|--python)
                 if [[ "$2" ]]; then
                     python="$2"
@@ -363,10 +370,11 @@ Usage: "${0}" [options]
 
 Options:
 
---develop       code remains editable in place (currently always enabled)
+--develop               code remains editable in place (currently always enabled)
---python, -p    python version (only python3 versions are supported)
+--disable-secp-check    do not run libsecp256k1 tests (default is to run them)
---with-qt       build the Qt GUI
+--python, -p            python version (only python3 versions are supported)
---without-qt    don't build the Qt GUI
+--with-qt               build the Qt GUI
+--without-qt            don't build the Qt GUI
 "
                 return 1
                 ;;
@@ -429,6 +437,7 @@ main ()
     # flags
     develop_build=''
     python='python3'
+    use_secp_check='1'
     with_qt=''
     reinstall='false'
     if ! parse_flags ${@}; then