Browse Source

Merge JoinMarket-Org/joinmarket-clientserver#1490: CI: Disable venv cache and remove editable installs

198117f14a CI: Remove editable installs (Kristaps Kaupe)
3641f1e1a4 Disable venv caching (Kristaps Kaupe)

Pull request description:

  See https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1479#issuecomment-1536741199. This seems to be at least increasing chances of CI to succeed. I commented out not removed venv cache part as a reminder that this is not what we want in a long term.

  `sed -i.bak` not just `sed -i` is to be compatible with both GNU (Linux) and macOS sed.

ACKs for top commit:
  AdamISZ:
    utACK 198117f14a

Tree-SHA512: 53c2135589be5e24df234e2d168d49a6d841769c4e4ec52227b7fb39c8c043400a9c402dea58fc28c6a1cc394fb580b32cda201f7289b6eb3bd33c8e70846822
master
Kristaps Kaupe 3 years ago
parent
commit
64b76d91e0
No known key found for this signature in database
GPG Key ID: 33E472FE870C7E5D
  1. 20
      .github/workflows/unittests.yml

20
.github/workflows/unittests.yml

@ -17,17 +17,19 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Cache venv
id: cache-venv
uses: actions/cache@v3
env:
cache-name: venv
with:
path: jmvenv
key: ${{ runner.os }}-${{ matrix.python-version }}-${{ env.cache-name }}-${{ hashFiles('requirements/*.txt', 'install.sh', '*/setup.py') }}
# - name: Cache venv
# id: cache-venv
# uses: actions/cache@v3
# env:
# cache-name: venv
# with:
# path: jmvenv
# key: ${{ runner.os }}-${{ matrix.python-version }}-${{ env.cache-name }}-${{ hashFiles('requirements/*.txt', 'install.sh', '*/setup.py') }}
- name: Setup joinmarket + virtualenv
if: steps.cache-venv.outputs.cache-hit != 'true'
# if: steps.cache-venv.outputs.cache-hit != 'true'
run: |
sed -i.bak 's/-e //g' requirements/base.txt
sed -i.bak 's/-e //g' requirements/gui.txt
./install.sh --develop --with-qt
./jmvenv/bin/python -m pip install --upgrade pip
./jmvenv/bin/pip install -r requirements/base.txt

Loading…
Cancel
Save