Browse Source

Merge JoinMarket-Org/joinmarket-clientserver#1630: Fix `get_tx_info()` type hint and doc

d9fee292f4 Fix get_tx_info() type hint and doc (Kristaps Kaupe)

Pull request description:

  `txid` is passed as binary `bytes` there, not hex string.

Top commit has no ACKs.

Tree-SHA512: 3e8272a5dc2291add827a06a5d0cda03652168e9d0cc3c9ec7532ace0522eef75c7e38c0dce6e665a65bb73d31579b2afda814fc18d0afcc99db311495642034
master
Kristaps Kaupe 2 years ago
parent
commit
3a6bea6ca8
No known key found for this signature in database
GPG Key ID: 33E472FE870C7E5D
  1. 4
      src/jmclient/wallet_utils.py

4
src/jmclient/wallet_utils.py

@ -365,12 +365,12 @@ class WalletView(WalletViewBase):
json_serialized.update(self.get_fmt_balance_json())
return json_serialized
def get_tx_info(txid: str, tx_cache: Optional[dict] = None) -> Tuple[
def get_tx_info(txid: bytes, tx_cache: Optional[dict] = None) -> Tuple[
bool, int, int, dict, int, btc.CTransaction]:
"""
Retrieve some basic information about the given transaction.
:param txid: txid as hex-str
:param txid: txid as binary
:param tx_cache: optional cache (dictionary) for get_transaction results
:return: tuple
is_coinjoin: bool

Loading…
Cancel
Save