Browse Source

Merge JoinMarket-Org/joinmarket-clientserver#1448: Fix libsecp256k1 commit ids in docs

f8af2bf1f6 Fix libsecp256k1 commit ids in docs (Kristaps Kaupe)

Pull request description:

  Noticed when reviewing #1444. Checked for all historical libsecp256k1 commits ids used historically with this:
  ```
  $ git grep -h secp256k1_lib_tar= $(git rev-list --all) | sort | uniq
      secp256k1_lib_tar="${secp256k1_version}.tar.gz"
      secp256k1_lib_tar='0d9540b13ffcd7cd44cc361b8744b93d88aa76ba'
      secp256k1_lib_tar='490022745164b56439688b0fc04f9bd43578e5c3'
      secp256k1_lib_tar='f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7'
  ```
  Then searched for old commit ids in whole repo (`grep -R commitid`).

  Using wrong libsecp256k1 may cause problems because of ABI changes.

Top commit has no ACKs.

Tree-SHA512: ad7276aa282a31114f707fb541394a892a0ebc0f5d324925a11297ebde2bb6133efc3655f0d274e5f620723ec97e6e9fb01de4ee16807d0f63184945595e25e0
master
Kristaps Kaupe 3 years ago
parent
commit
33dc800605
No known key found for this signature in database
GPG Key ID: 33E472FE870C7E5D
  1. 4
      docs/INSTALL.md

4
docs/INSTALL.md

@ -57,7 +57,7 @@ Then build and install a local copy of libsecp256k1 for python-bitcointx:
cd deps
git clone git@github.com:bitcoin-core/secp256k1
cd secp256k1
git checkout 0d9540b13ffcd7cd44cc361b8744b93d88aa76ba
git checkout 490022745164b56439688b0fc04f9bd43578e5c3
make clean
./autogen.sh
./configure --prefix JM_ROOT --enable-module-recovery --disable-jni --enable-experimental --enable-module-ecdh --enable-benchmark=no
@ -97,7 +97,7 @@ If you have installed this "full" version of the client, you can use it with the
```
git clone https://github.com/bitcoin-core/secp256k1
cd secp256k1
git checkout 0d9540b13ffcd7cd44cc361b8744b93d88aa76ba
git checkout 490022745164b56439688b0fc04f9bd43578e5c3
./autogen.sh
./configure --enable-module-recovery --disable-jni --enable-experimental --enable-module-ecdh --enable-benchmark=no
make

Loading…
Cancel
Save