Browse Source

Merge JoinMarket-Org/joinmarket-clientserver#1190: fix: improve NotEnoughCoinsForMaker error message

06dc4f7a05 fix: improve NotEnoughCoinsForMaker error message (Thebora Kompanioni)

Pull request description:

  Changes the error message when the maker cannot start due to not enough coins from:
  `"Maker could not start, no coins."` to `"Maker could not start, no confirmed coins."`

  According to @AdamISZ [here](https://github.com/joinmarket-webui/joinmarket-webui/issues/34#issuecomment-1032558663) this could be an improvement for the user, as it might make it clear that coins need to mature.

  Please just dismiss if you think it's not a good idea.

  Edit: The newline change has been made by GitHub automatically.. 🤔

ACKs for top commit:
  kristapsk:
    utACK 06dc4f7a05

Tree-SHA512: c72441e1050ec664248da01bd2df9a3fc95cf7477ea512d876797e4798ae5d915771821efa42a7de4da71df08295d796517f5eda2aabd49eb171ecc2529d9b82
master
Kristaps Kaupe 4 years ago
parent
commit
2d524eaeaf
No known key found for this signature in database
GPG Key ID: 33E472FE870C7E5D
  1. 4
      jmclient/jmclient/wallet_rpc.py

4
jmclient/jmclient/wallet_rpc.py

@ -318,7 +318,7 @@ class JMWalletDaemon(Service):
def not_enough_coins(self, request, failure):
# as above, 409 may not be ideal
request.setResponseCode(409)
return self.err(request, "Maker could not start, no coins.")
return self.err(request, "Maker could not start, no confirmed coins.")
@app.handle_errors(YieldGeneratorDataUnreadable)
def yieldgenerator_report_unavailable(self, request, failure):
@ -1025,4 +1025,4 @@ class JMWalletDaemon(Service):
if not self.wallet_name == walletname:
raise InvalidRequestFormat()
seedphrase, _ = self.services["wallet"].get_mnemonic_words()
return make_jmwalletd_response(request, seedphrase=seedphrase)
return make_jmwalletd_response(request, seedphrase=seedphrase)

Loading…
Cancel
Save