From 3ccd3954c761f8738eceeb478f5278b23cb8ff8a Mon Sep 17 00:00:00 2001 From: qubenix Date: Thu, 3 Jan 2019 12:52:16 +0000 Subject: [PATCH 1/3] add help menu to install.sh --- install.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/install.sh b/install.sh index b120f94..c2a74fc 100755 --- a/install.sh +++ b/install.sh @@ -356,11 +356,9 @@ parse_flags () --with-qt) with_qt='1' ;; - -?*) - echo "warning. unknown flag : $1" 1>&2 - ;; *) - break + echo -e "\nUsage: "${0}" [options]\n\nOptions:\n\n--develop code remains editable in place\n--python, -p python version: python2 or python3 (default: python2)\n--with-qt build the Qt GUI (incompatible with python2)\n" + exit 1 esac shift done From c8ff3231d16ed1a54767eff6581a28d95fc50f47 Mon Sep 17 00:00:00 2001 From: qubenix Date: Thu, 3 Jan 2019 15:56:18 +0000 Subject: [PATCH 2/3] fixup --- install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install.sh b/install.sh index c2a74fc..0359ecc 100755 --- a/install.sh +++ b/install.sh @@ -357,7 +357,7 @@ parse_flags () with_qt='1' ;; *) - echo -e "\nUsage: "${0}" [options]\n\nOptions:\n\n--develop code remains editable in place\n--python, -p python version: python2 or python3 (default: python2)\n--with-qt build the Qt GUI (incompatible with python2)\n" + echo -e "\nUsage: "${0}" [options]\n\nOptions:\n\n--develop code remains editable in place\n--python, -p python version (default: python2)\n--with-qt build the Qt GUI (incompatible with python2)\n" exit 1 esac shift From 4abe512cd5b43dd3db86913b14213f6d0db7fa55 Mon Sep 17 00:00:00 2001 From: qubenix Date: Thu, 3 Jan 2019 17:36:46 +0000 Subject: [PATCH 3/3] fixup: fivepiece suggestions --- install.sh | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/install.sh b/install.sh index 0359ecc..bea22f9 100755 --- a/install.sh +++ b/install.sh @@ -356,9 +356,21 @@ parse_flags () --with-qt) with_qt='1' ;; + "") + break + ;; *) - echo -e "\nUsage: "${0}" [options]\n\nOptions:\n\n--develop code remains editable in place\n--python, -p python version (default: python2)\n--with-qt build the Qt GUI (incompatible with python2)\n" - exit 1 + echo " +Usage: "${0}" [options] + +Options: + +--develop code remains editable in place +--python, -p python version (default: python2) +--with-qt build the Qt GUI (incompatible with python2) +" + return 1 + ;; esac shift done