Merge #382: Sendpayment/Tumbler: fix division by 0 error

d62a300 Fix sweeps with N=0 counterparties, which otherwise fails because the amount was changed from 0 too early (AlexCato)
b656f85 Sendpayment/Tumbler: fix division by 0 error on sweeps (AlexCato)

scripts/sendpayment.py

@@ -115,17 +115,6 @@ def main():
             options.txfee))
     assert (options.txfee >= 0)
 
-    # From the estimated tx fees, check if the expected amount is a
-    # significant value compared the the cj amount
-    exp_tx_fees_ratio = ((1 + options.makercount) * options.txfee) / amount
-    if exp_tx_fees_ratio > 0.05:
-        jmprint('WARNING: Expected bitcoin network miner fees for this coinjoin'
-            ' amount are roughly {:.1%}'.format(exp_tx_fees_ratio), "warning")
-    else:
-        log.info("Estimated miner/tx fees for this coinjoin amount: {:.1%}"
-            .format(exp_tx_fees_ratio))
-
-
     maxcjfee = (1, float('inf'))
     if not options.p2ep and not options.pickorders and options.makercount != 0:
         maxcjfee = get_max_cj_fee_values(jm_single().config, options)
@@ -146,6 +135,25 @@ def main():
     #wallet sync will now only occur on reactor start if we're joining.
     while not jm_single().bc_interface.wallet_synced:
         sync_wallet(wallet, fast=options.fastsync)
+
+    # From the estimated tx fees, check if the expected amount is a
+    # significant value compared the the cj amount
+    total_cj_amount = amount
+    if total_cj_amount == 0:
+        total_cj_amount = wallet.get_balance_by_mixdepth()[options.mixdepth]
+        if total_cj_amount == 0:
+            raise ValueError("No confirmed coins in the selected mixdepth. Quitting")
+    exp_tx_fees_ratio = ((1 + options.makercount) * options.txfee) / total_cj_amount
+    if exp_tx_fees_ratio > 0.05:
+        jmprint('WARNING: Expected bitcoin network miner fees for this coinjoin'
+            ' amount are roughly {:.1%}'.format(exp_tx_fees_ratio), "warning")
+        if input('You might want to modify your tx_fee'
+            ' settings in joinmarket.cfg. Still continue? (y/n):')[0] != 'y':
+            sys.exit('Aborted by user.')
+    else:
+        log.info("Estimated miner/tx fees for this coinjoin amount: {:.1%}"
+            .format(exp_tx_fees_ratio))
+
     if options.makercount == 0 and not options.p2ep:
         direct_send(wallet, amount, mixdepth, destaddr, options.answeryes)
         return

scripts/tumbler.py

@@ -124,6 +124,8 @@ def main():
                             max_mix_depth)
     for i in range(options['mixdepthsrc'], max_mix_to_tumble):
         total_tumble_amount += wallet.get_balance_by_mixdepth()[i]
+        if total_tumble_amount == 0:
+            raise ValueError("No confirmed coins in the selected mixdepth(s). Quitting")
     exp_tx_fees_ratio = (involved_parties * options['txfee']) \
         / total_tumble_amount
     if exp_tx_fees_ratio > 0.05: