SomberNight
b95fbbb86f
wizard: fix regression: allow passphrase for some '2fa' seeds
...
fixes https://github.com/spesmilo/electrum/issues/9088
2 years ago
Sander van Grieken
b11d0062e8
wizard: log state when view not defined. ref #8815
2 years ago
Sander van Grieken
d6ea2f1e30
wizard: log state when view not defined. ref #8916
2 years ago
SomberNight
b4712397cc
logging: (trivial) use repr() of seed_type
...
for more obvious empty string
related: https://github.com/spesmilo/electrum/issues/4326#issuecomment-1903747632
2 years ago
Sander van Grieken
8ce1e6453b
wizard: skip/hide passphrase option for 'old' and '2fa' seeds (see #4326 )
2 years ago
SomberNight
8ab3dcce5d
keystore: API changes for from_seed/from_bip43_rootseed/bip39_to_seed
...
- force kwargs
- add type hints
2 years ago
SomberNight
46ce5d0f3d
wizard: (trivial) follow-up prev
2 years ago
SomberNight
638fdf114e
wizard: don't log sensitive values: replace blacklist with whitelist
...
- blacklist was missing yet another item "multisig_master_pubkey"
- let's just do a whitelist. a blacklist is too risky for my liking here.
2 years ago
SomberNight
acae6751d2
wizard: do not log sensitive data (add more keys, again)
...
frankly this blacklist approach seems too fragile...
2 years ago
Sander van Grieken
82c21bc30d
wizard: take hardware_device from correct location for cosigners. fixes #8808
2 years ago
SomberNight
683c6083c9
wizard: do not log sensitive data (add more keys)
2 years ago
Sander van Grieken
ebcecdccce
qt,qml: add checkboxes for advanced network config on welcome page, remove separate proxy-ask and autoconnect pages
2 years ago
Sander van Grieken
5e39ff49bc
add missing accept handler for welcome page
2 years ago
Sander van Grieken
a03b2d7bae
qt,qml: add a welcome page as initial page for server connect wizard
...
This is much less intimidating than asking if the user wants to use a proxy
out of the gate.
2 years ago
Sander van Grieken
b87d091a6d
qt, qml: allow BIP39 seeds which fail checksum or wordlist ( fixes #8720 )
...
removes verifySeed from qebitcoin as this code was 99% duplicate of wizard.validate_seed
2 years ago
SomberNight
f7cb523b9d
wallet db: deduplicate "seed_type" field
...
In the db, the 'seed_type' field could be present both at the top-level and inside keystores.
Note:
- both fields had usages
- the top-level field was added in 2.8 re "initial segwit support" (3a64ec0f2e )
- there was no db upgrade for it, so older files are missing it
- if present, valid values can be electrum types but also
other types supported by the wizard, e.g. "bip39"
- the keystore-level field was added in 4.1 (7b7bba2299 )
- there was a db upgrade when it was introduced, so old files also have it
- if present, valid values can only be electrum types
- there is not much value in the top-level one having a non-electrum value,
and those values were never used by other parts of the code
- note that when creating a standard wallet from a bip39 seed, the seed is discarded.
Only the derived xprv and the derivation path are kept. If we changed this and also kept the seed,
e.g. to display it to the user, then it would make sense to save the seed type (e.g. "bip39").
However storing that seed_type would make more sense at the keystore level (not top-level).
We delete the top-level 'seed_type' field.
```
{
"keystore": {
"seed_type": "segwit",
...
},
"seed_type": "segwit",
...
}
```
2 years ago
SomberNight
564b6c29b7
wizard: fix self._logger vs self.logger
...
AttributeError: 'QENewWalletWizard' object has no attribute 'logger'
2 years ago
ThomasV
56e80c20d7
wallet_db upgrade: do not use '/' in StoredDict keys
2 years ago
ThomasV
68159b3ef6
walletDB: replace 'manual_upgrades' parameter with 'upgrade', with opposite semantics
2 years ago
Sander van Grieken
44a1595157
wizard: don't use hww encryption of wallet files for anything besides standard wallets,
...
check hw wallet file decrypt in WCHWUnlock,
fix assumption 'wallet_type' exists in wallet open scenario.
2 years ago
Sander van Grieken
2caa8f13cf
wizard: make wizard.keystore_from_data more robust;
...
- always store 'keystore_type' in cosigner data and use same types as main
- dont share 'hardware_device' in root of dict, but store for each cosigner
- properly return hardware keystore for hardware cosigners
2 years ago
Sander van Grieken
808f1877d2
wizard: allow slip39 for multisig
...
also, consistent single quoting of strings
2 years ago
Sander van Grieken
ec0dbc78c2
wizard: fix assumption 'keystore_type' is present in wizard_data, fix unexpected keystore type msg
2 years ago
Sander van Grieken
7fd3b6c91d
wizard: remove finished call, it's unused
...
qt: call is_finalized before closing the wizard dialog and add a check if wallet can be
decrypted with the supplied secret (user pw, hw device)
2 years ago
Sander van Grieken
314e3f958d
qt: new wizard 2fa offline setup
2 years ago
Sander van Grieken
8663d89f77
qt: add HWW unlock wizardcomponent
2 years ago
Sander van Grieken
b072f5d243
wizard: typing
2 years ago
Sander van Grieken
83c2eb46bb
qt: initial open existing wallet from wizard,
...
set window title for wizard dialogs,
catch RuntimeError for WizardComponent.updated signal, widget might be gone
2 years ago
Sander van Grieken
2a2459c649
qt: implement server picker in server connect wizard
2 years ago
Sander van Grieken
902290ee8c
qt: multisig checks with hardware cosigners
2 years ago
Sander van Grieken
b7ed4c569b
wip. trezor works for standard wallet, also for cosigners
2 years ago
Sander van Grieken
bcdacf3773
wizard: add passing of params in navmap to wizard pages
2 years ago
Sander van Grieken
a6caa3ffe9
wizard: fix wizard_data instance not isolated between pages,
...
combine is_bip39_seed and is_slip39_seed into cosigner aware needs_derivation_path
add instance id logging to wizard.log_stack()
qt: add updated signal to SeedLayout
2 years ago
Sander van Grieken
c485753ffd
wizard: rename bip39_refine to script_and_derivation
2 years ago
Sander van Grieken
0222c93228
wizard: add support for slip39
2 years ago
Sander van Grieken
d395b97e83
qt: add have_master_key gui, implement cosigners in have_seed and bip39_refine guis
...
fix adding data from accept handler
2 years ago
Sander van Grieken
2407fab178
wizard: also push final state on the stack
2 years ago
Sander van Grieken
786eab9cfd
wizard: cleanup, variable naming consistency, imports, invalid accept handler now raises
2 years ago
Sander van Grieken
9e096fbf1e
wizard: remove view from is_last_view call, it's never used
2 years ago
SomberNight
7482e275b9
follow-up storage/db changes
...
follow-up b96cc82333
2 years ago
ThomasV
b96cc82333
Make storage a field of db
...
This comes from the jsonpatch_new branch.
I rather have in master now, because it touches a lot of filese.
2 years ago
Sander van Grieken
8cd95f1f7f
qml: limit BIP39 cosigners script type to initial choice (bip39) or initial seed (electrum)
3 years ago
SomberNight
d2cf21fc2b
qml wizard: enforce homogeneous master keys in multisig
...
- {xpub, Ypub, Zpub} categories cannot be mixed
- old mpk must not be used in multisig
3 years ago
SomberNight
f5f177f7e8
qml wizard: fix restoring from old mpk (watchonly for "old" seeds)
...
fixes https://github.com/spesmilo/electrum/issues/8356
3 years ago
SomberNight
b429992e77
wizard.py: don't use mutable default args
3 years ago
SomberNight
e9aad6896e
wizard.py: change stack to be per-instance
...
seems less error-prone
3 years ago
SomberNight
fd9a90f3b6
wizard.py: fix clearing stack between wizards
...
try finishing a wizard and then launching a new one: the new one kept
building on top of the stack of the prev wizard
3 years ago
SomberNight
ad58916729
wizard.py: (trivial) fix type hint and an f-string
3 years ago
Sander van Grieken
3b7fa89e44
wizard: p2sh multisig is 'standard' in backend wallet
3 years ago
SomberNight
48e37696b3
qml wizard: fix creating wallet from master key
...
fixes https://github.com/spesmilo/electrum/issues/8260
3 years ago