SomberNight
66b8ec1833
trustedcoin: rm some dead code
...
used by old qt wizard
2 years ago
SomberNight
683c6083c9
wizard: do not log sensitive data (add more keys)
2 years ago
SomberNight
77c55d78b7
qt wizard: show warning when trying to restore 2fa seed as std wallet
...
With wallet_type=="standard", if the user enters a 2fa electrum seed, the "next" btn is disabled.
This is a regression in the new wizard, the old one used to "redirect" seamlessly.
This commit does not fix this, but at least shows a user-friendly warning message.
Note: would be nice if the wizard redirected automatically, in both directions (2fa->std, std->2fa).
The old wizard implemented std->2fa (probably the more common case hit by users), and had this
warning message shown for the 2fa->std case. Now I am repurposing the warning also for std->2fa.
2 years ago
SomberNight
dab768b932
qt/wizard/wallet: improve typing: introduce WalletWizardComponent cls
2 years ago
SomberNight
37173845c2
qt wizard: WizardComponent: (fix) also inherit ABC
...
for `@abstractmethod` decorator to work
(except, turns out, it's not so simple because of pyqt's own magic for QWidget)
2 years ago
SomberNight
201c0ab71b
qt wizard: fix restoring from 2fa seed
...
follow-up 7df057aaf9
2 years ago
SomberNight
3b630c7a5b
tests: add "short seed cheat sheet"
...
hopefully I can remember what to ctrl+f to find this
2 years ago
accumulator
35d4cf4d09
Merge pull request #8788 from accumulator/qml_non_historic_fiat
...
qml: don't show fiat amount when timestamp more than a day old and historic rates are disabled
2 years ago
accumulator
a51b3bdbfb
qml: show fiat price when historic rates are enabled and no timestamp available
...
Co-authored-by: ghost43 <somber.night@protonmail.com>
2 years ago
ghost43
926756c6cc
Merge pull request #8789 from accumulator/bip21_req_params_validation
...
bip21: fail bip21 uri if unsupported req-* parameter is present.
2 years ago
SomberNight
bd88b6ba29
tests: add unit test for prev
2 years ago
Sander van Grieken
313b79cfaf
qml: add txid not empty assert to removeLocalTx. ref #8775
2 years ago
Sander van Grieken
0b7fa9cd99
bip21: fail bip21 uri if unsupported req-* parameter is present. fixes #8781
2 years ago
Sander van Grieken
5077e013f3
qml: don't show fiat amount when timestamp more than a day old and historic rates are disabled
2 years ago
MrNaif2018
9b5bead6f4
Restore ability to pass wallet in-memory
2 years ago
accumulator
88058df409
Merge pull request #8772 from accumulator/qml_tx_inputs
...
qml: add transaction inputs in TxDetails and …
2 years ago
Sander van Grieken
92bff08ba5
qml: don't use predictive text for fields where it makes no sense
2 years ago
Sander van Grieken
3935e378b3
android: p4a ref d976b539dc7c808d103a7edfe6dc1fd300582a89
...
> don't keep build dir around after succesful build
2 years ago
Sander van Grieken
c1ebc42724
android: p4a ref f534fe9bcd692c4df97e644d34c5bd8acede01eb
...
> qt6: don't copy entire build tree to dist, use select set of include patterns.
2 years ago
Sander van Grieken
e8852918a7
qml: fix newline in TxDetails
2 years ago
Sander van Grieken
7164392b1c
qml: add transaction inputs in TxDetails and ConfirmTxDialog, RbfBumpFeeDialog, RbfCancelDialog, CpfpBumpFeeDialog
...
and allow collapse/expand of input/output lists by clicking on label.
2 years ago
SomberNight
eee61a98cb
gui: cpfp: calc parent fee for cpfp using wallet.get_tx_info
...
I am only making this change as it makes it simpler to do manual testing of CPFP-ing *local* txs.
That is, by changing a few easy-to-find lines of code, I can make the GUI allow CPFP-ing a local tx, but
without this change it errors out with "unknown fee for parent transaction".
If one has an incoming local tx saved in the wallet, adb.get_tx_fee(txid) returns None
(if the tx gets into the mempool, it will use the server-reported value instead).
In contrast, wallet.get_tx_info(tx).fee calls both wallet.get_wallet_delta(tx) and adb.get_tx_fee(txid),
making it more expensive but more complete.
2 years ago
Sander van Grieken
ceb42c2a1b
qml: show frozen lightning balance in BalanceDetails only when non-zero
2 years ago
SomberNight
0dae17339d
qml: add config setting to allow screenshots
...
On Android, we disallow screenshots on screens where the seed is visible.
(The seed is extremely sensitive data that should not be stored digitally without
significant precautions but it's also cumbersome to write down or memorise, so
some people instinctively just try to take a screenshot of it when creating a wallet.)
We do this by using the built-in OS mechanism of setting FLAG_SECURE on the window.
However, on some devices with custom ROMs (one report from LineageOS, one from /e/OS),
unsetting FLAG_SECURE crashes the application for some reason.
As a workaround, this commit adds a config setting into the Preferences,
to disable this mechanism and just always allow screenshots.
(note that you can get into the qml Preferences before creating/opening any wallet)
ref https://github.com/spesmilo/electrum/issues/8522
2 years ago
accumulator
9ea15a1c3c
Merge pull request #8737 from accumulator/welcome_page
...
qt,qml: add a welcome page as initial page for server connect wizard
2 years ago
SomberNight
d54184dbc1
fix some DeprecationWarnings in python3.12
...
...\electrum\electrum\logging.py:137: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
...\electrum\electrum\x509.py:310: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
2 years ago
SomberNight
3d1009f7e2
tests: fix TestLNTransport.test_loop for python 3.12
...
Semantics for server.wait_closed changed in 3.12, and it was always
a no-op in our usage in prior versions.
see https://github.com/python/cpython/issues/104344
2 years ago
SomberNight
872ab29436
android build: bump some security-sensitive packages (py3, ssl)
2 years ago
SomberNight
615cb66692
appimage build: bump python version (3.10.11->3.10.13)
2 years ago
SomberNight
25c50f15c0
qt TxEditor: fix extraneous "not able to RBF later" warning
...
Imported wallets, and HD wallets with "use change" disabled, would always
get the warning before.
2 years ago
Sander van Grieken
4908c8c389
qml: RbfCancelDialog: warning text in frame
2 years ago
accumulator
d8bd55bf4e
Merge pull request #8758 from accumulator/qml_error_dialogs
...
qml: use warning icon and error title for failure messagedialogs
2 years ago
sha-265
92a08a5fe7
Add Bit2C exchange ( #8767 )
...
* Add Bit2C exchange
* Remove whitespace
---------
Co-authored-by: sha-265 <sha@mempool.party>
2 years ago
Sander van Grieken
cb34bbee7e
qml: don't enable save button for already saved invoices
2 years ago
accumulator
bec74304b6
Merge pull request #8759 from accumulator/qml_remove_unused
...
qml remove unused components
2 years ago
Sander van Grieken
adcc9eb2d1
qml: qewallet code style
2 years ago
Sander van Grieken
c7e055bdb9
qml: remove unused components
2 years ago
Sander van Grieken
ebcecdccce
qt,qml: add checkboxes for advanced network config on welcome page, remove separate proxy-ask and autoconnect pages
2 years ago
SomberNight
2ea723a91a
tests: add test for bip39 utf-8 normalisation
...
test case from https://github.com/Electron-Cash/Electron-Cash/issues/2740
2 years ago
Sander van Grieken
5e39ff49bc
add missing accept handler for welcome page
2 years ago
Sander van Grieken
a03b2d7bae
qt,qml: add a welcome page as initial page for server connect wizard
...
This is much less intimidating than asking if the user wants to use a proxy
out of the gate.
2 years ago
Sander van Grieken
6e576f2a08
qml: fix cancelling network wizard not closing app
2 years ago
accumulator
1d574808e2
Merge pull request #8762 from SomberNight/202312_qml_wiz_serverconfig
...
qml: WCServerConfig.qml: only disable autoconnect if given server
2 years ago
SomberNight
3b5b75325e
qml: WCServerConfig.qml: only disable autoconnect if given server
...
if the user entered the server select screen and immediately clicked next,
a random server would get set but with auto_connect disabled.
2 years ago
Sander van Grieken
524adaf747
qml: use warning icon and error title for failure messagedialogs
2 years ago
Sander van Grieken
4382578235
qml: android.minapi and android.ndk_api to 23 (android 6.0+)
2 years ago
SomberNight
be9dc06aaf
contrib/add_cosigner: print "usage: ..." if called incorrectly
2 years ago
accumulator
d0276831fa
Merge pull request #8760 from sha-265/patch-1
...
Add new duplicate outputs merge option to changelog
2 years ago
sha-265
2a81e84abc
Update RELEASE-NOTES
2 years ago
SomberNight
1d4a5052ef
labels plugin: add FIXMEs. don't roll your own crypto...
...
```
23.76 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 180
set_label. label='a1'. item='444dffaf758a1b17893cbc8dda4032f9b6e9f61115e7c1a6d486a0950de50c11'. bundle['encryptedLabel']='WzqTZD+cnoQEUrfYsBz0rg=='
28.10 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 181
set_label. label='a1'. item='4812e9844c958a913a71a5a728ea6d73e42d0618f96a4259bad1895b4f427f8e'. bundle['encryptedLabel']='WzqTZD+cnoQEUrfYsBz0rg=='
set_label. label='a1'. item='c5daddf7972e16e25c1362d492888a8bbf3d8dcfc789342d71dc83d9a8faaa6c'. bundle['encryptedLabel']='WzqTZD+cnoQEUrfYsBz0rg=='
36.51 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 182
set_label. label='a1'. item='be5973ddf9b6ae6949e544c3cf43a16e2a8719dcf14a1171ec94cfa25d4a3325'. bundle['encryptedLabel']='WzqTZD+cnoQEUrfYsBz0rg=='
45.68 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 183
set_label. label=''. item='444dffaf758a1b17893cbc8dda4032f9b6e9f61115e7c1a6d486a0950de50c11'. bundle['encryptedLabel']='yErvsmjQUEt4Ry8c55S3Mg=='
55.99 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 184
58.69 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 185
set_label. label=''. item='4812e9844c958a913a71a5a728ea6d73e42d0618f96a4259bad1895b4f427f8e'. bundle['encryptedLabel']='yErvsmjQUEt4Ry8c55S3Mg=='
set_label. label=''. item='c5daddf7972e16e25c1362d492888a8bbf3d8dcfc789342d71dc83d9a8faaa6c'. bundle['encryptedLabel']='yErvsmjQUEt4Ry8c55S3Mg=='
60.98 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 186
set_label. label=''. item='be5973ddf9b6ae6949e544c3cf43a16e2a8719dcf14a1171ec94cfa25d4a3325'. bundle['encryptedLabel']='yErvsmjQUEt4Ry8c55S3Mg=='
62.80 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 187
```
2 years ago