Sander van Grieken
adcc9eb2d1
qml: qewallet code style
2 years ago
Sander van Grieken
c7e055bdb9
qml: remove unused components
2 years ago
Sander van Grieken
ebcecdccce
qt,qml: add checkboxes for advanced network config on welcome page, remove separate proxy-ask and autoconnect pages
2 years ago
SomberNight
2ea723a91a
tests: add test for bip39 utf-8 normalisation
...
test case from https://github.com/Electron-Cash/Electron-Cash/issues/2740
2 years ago
Sander van Grieken
5e39ff49bc
add missing accept handler for welcome page
2 years ago
Sander van Grieken
a03b2d7bae
qt,qml: add a welcome page as initial page for server connect wizard
...
This is much less intimidating than asking if the user wants to use a proxy
out of the gate.
2 years ago
Sander van Grieken
6e576f2a08
qml: fix cancelling network wizard not closing app
2 years ago
accumulator
1d574808e2
Merge pull request #8762 from SomberNight/202312_qml_wiz_serverconfig
...
qml: WCServerConfig.qml: only disable autoconnect if given server
2 years ago
SomberNight
3b5b75325e
qml: WCServerConfig.qml: only disable autoconnect if given server
...
if the user entered the server select screen and immediately clicked next,
a random server would get set but with auto_connect disabled.
2 years ago
Sander van Grieken
524adaf747
qml: use warning icon and error title for failure messagedialogs
2 years ago
Sander van Grieken
4382578235
qml: android.minapi and android.ndk_api to 23 (android 6.0+)
2 years ago
SomberNight
be9dc06aaf
contrib/add_cosigner: print "usage: ..." if called incorrectly
2 years ago
accumulator
d0276831fa
Merge pull request #8760 from sha-265/patch-1
...
Add new duplicate outputs merge option to changelog
2 years ago
sha-265
2a81e84abc
Update RELEASE-NOTES
2 years ago
SomberNight
1d4a5052ef
labels plugin: add FIXMEs. don't roll your own crypto...
...
```
23.76 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 180
set_label. label='a1'. item='444dffaf758a1b17893cbc8dda4032f9b6e9f61115e7c1a6d486a0950de50c11'. bundle['encryptedLabel']='WzqTZD+cnoQEUrfYsBz0rg=='
28.10 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 181
set_label. label='a1'. item='4812e9844c958a913a71a5a728ea6d73e42d0618f96a4259bad1895b4f427f8e'. bundle['encryptedLabel']='WzqTZD+cnoQEUrfYsBz0rg=='
set_label. label='a1'. item='c5daddf7972e16e25c1362d492888a8bbf3d8dcfc789342d71dc83d9a8faaa6c'. bundle['encryptedLabel']='WzqTZD+cnoQEUrfYsBz0rg=='
36.51 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 182
set_label. label='a1'. item='be5973ddf9b6ae6949e544c3cf43a16e2a8719dcf14a1171ec94cfa25d4a3325'. bundle['encryptedLabel']='WzqTZD+cnoQEUrfYsBz0rg=='
45.68 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 183
set_label. label=''. item='444dffaf758a1b17893cbc8dda4032f9b6e9f61115e7c1a6d486a0950de50c11'. bundle['encryptedLabel']='yErvsmjQUEt4Ry8c55S3Mg=='
55.99 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 184
58.69 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 185
set_label. label=''. item='4812e9844c958a913a71a5a728ea6d73e42d0618f96a4259bad1895b4f427f8e'. bundle['encryptedLabel']='yErvsmjQUEt4Ry8c55S3Mg=='
set_label. label=''. item='c5daddf7972e16e25c1362d492888a8bbf3d8dcfc789342d71dc83d9a8faaa6c'. bundle['encryptedLabel']='yErvsmjQUEt4Ry8c55S3Mg=='
60.98 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 186
set_label. label=''. item='be5973ddf9b6ae6949e544c3cf43a16e2a8719dcf14a1171ec94cfa25d4a3325'. bundle['encryptedLabel']='yErvsmjQUEt4Ry8c55S3Mg=='
62.80 | I | plugins.labels.qt.Plugin | set test_segwit_2 nonce to 187
```
2 years ago
SomberNight
e08302ac4a
release.sh: fix missing android apk names
...
follow-up e441d4b15e
These are used later in the script.
2 years ago
SomberNight
51bc23c92f
build scripts: (trivial) add quotes around some shell variables
2 years ago
SomberNight
a936e7720b
gitignore: add release-process-related artefacts
2 years ago
ThomasV
636195bc6e
update version to 4.5.0b1
2 years ago
SomberNight
b5d8d31723
plugins: follow-up prev, log thread name when loading plugins
...
Correction to comment in prev commit (and removing it here):
spec.loader.exec_module does not spawn new threads, it simply
executes the module in the current thread.
I got confused but turns out "load_plugin" itself is sometimes
not called from the main thread. Specifically (e.g.), since the recent
wizard rewrite, in the qt gui, the wizard loads the hww plugins
from a new thread.
This now better explains the macos hww crashes: they had started
appearing because we upgraded hidapi (which made it more sensitive
to having to import from main thread) AND scanning(->importing) from
the wizard no longer happened on the main thread after the rewrite.
Plugins should be thread-safe in terms of where they are imported from.
Let's log the importer thread's name (added here), to help recognise
related threading issues.
2 years ago
SomberNight
740016e0d5
hw wallets: fix crashes on macOS
...
related https://github.com/trezor/cython-hidapi/pull/150#issuecomment-1542391087
2 years ago
SomberNight
bf4934bb9f
android build: update p4a fork with qt6 build repro fixes
...
related https://github.com/spesmilo/electrum/issues/8746
2 years ago
ThomasV
2d954bb554
payserver plugin: remove support for qt GUI.
...
(This plugin is not useful without a daemon)
fixes #8748
2 years ago
SomberNight
adb1db57ff
android readme: update commands in "reproducibility fail" section
...
I think file was renamed in upstream p4a
2 years ago
SomberNight
9c7b2bd877
mac build: log hash of .app for quick checking of build-repro
...
I think that hash should match between unsigned and release builds,
as the codesigning/notarisation is done right after.
2 years ago
SomberNight
5f309e95c8
release.sh: don't hardcode ".0" suffix in APK_VERSION
...
does not work with current beta:
```
d142c5534f4da4a7f0a1f52676716908f674ff9e06b87f7b153384b161296eaf /home/user/wspace/electrum/contrib/android/../../dist/Electrum-4.5.0.0-armeabi-v7a-release-unsigned.apk
+ mv dist/Electrum-4.5.0b0.0-armeabi-v7a-release-unsigned.apk dist/Electrum-4.5.0b0.0-armeabi-v7a-release.apk
mv: cannot stat 'dist/Electrum-4.5.0b0.0-armeabi-v7a-release-unsigned.apk': No such file or directory
```
2 years ago
SomberNight
f4cddd7335
update block header checkpoints
2 years ago
ThomasV
b21fed0142
update locale submodule
2 years ago
SomberNight
a027a70361
prepare release 4.5.0b0
...
note: rm-ed the trustedcoin item from the release-notes as it was backported and already released
2 years ago
ThomasV
856163f096
Merge pull request #8743 from SomberNight/202312_sighash_warnings
...
wallet: refactor check_sighash/risk_of_burning_coins_as_fees
2 years ago
ThomasV
70527f98d4
release notes:
...
- remove redundant item (already in previous release)
- describe new swap flow in a single place
2 years ago
ThomasV
d691aa0736
qt: add 'notes' tab
2 years ago
SomberNight
2bc056ed33
wallet: refactor check_sighash/risk_of_burning_coins_as_fees
...
- risk_of_burning_coins_as_fees is turned into a private (helper) method, only called by check_sighash.
UIs should only care about check_sighash.
- check_sighash returns instance of new class "TxSighashDanger" instead of tuple
- made warning levels more fine-grained (FEE_WARNING_SKIPCONFIRM vs FEE_WARNING_NEEDCONFIRM)
- this became more complicated than I had hoped for but I think it is worth it to ~merge
check_sighash and risk_of_burning_coins_as_fees into one.
related https://github.com/spesmilo/electrum/pull/8699
2 years ago
SomberNight
52771670f2
tests: add test for wallet.check_sighash
...
related https://github.com/spesmilo/electrum/pull/8699
2 years ago
Sander van Grieken
321f6255fa
qt: do not proceed to wallet setup when cancelling network wizard
2 years ago
Sander van Grieken
8ba7a00097
qml: update new labels in history and addresscoinlist
2 years ago
Sander van Grieken
3a22cb9c48
labels: emit callback when labels received.
...
write labels regardless if there's already a label set for an ID.
2 years ago
SomberNight
e1d0247ce4
wallet: clarify difference between wallet.is_mine and adb.is_mine
...
related https://github.com/spesmilo/electrum/pull/8699
2 years ago
SomberNight
a36e7a4d28
build: partial rerun freeze_packages
...
just update a few key packages
trezorlib update might fix https://github.com/spesmilo/electrum/issues/8722 (untested)
2 years ago
Sander van Grieken
831be3b680
network: fix issue starting tor probe when proxy disabled
2 years ago
Sander van Grieken
a6ceeec09d
qml: add frozen lightning to BalanceDetails, indent frozen on-chain and lightning amounts
2 years ago
Sander van Grieken
297f971fae
qml: improve info text for incomplete transactions and transactions in mempool on transaction details page.
2 years ago
ThomasV
c1b359d43f
Merge pull request #8738 from SomberNight/202312_mac_build
...
mac build: migrate to new VM (macOS 10.14 -> 11)
2 years ago
SomberNight
dd3fc041f9
qt main window: statusbar: swap Tor and Network buttons
...
I think it's nicer for the network status to be rightmost, which was the case for a long time.
(Though plugins are still added after (via multiple different mechanisms, see 2fa, hww, revealer).
We could perhaps add a VLine separator, or add them to the left instead.)
follow-up 90d1d587e8
2 years ago
SomberNight
c52853341c
qt util: add VLine class, for vertical line separators
2 years ago
SomberNight
da775954c0
qt wizard: fix wallets directory relative paths on Windows
...
follow-up https://github.com/spesmilo/electrum/pull/8651
We cannot do direct comparison of path-like strings without normalisation.
E.g.
```
relative_path() cp1. path='c:\\users\\user\\appdata\\roaming\\electrum\\wallets\\9dk', wallets=C:\Users\User\AppData\Roaming\Electrum\wallets
relative_path() cp2. commonpath='c:\\users\\user\\appdata\\roaming\\electrum\\wallets'
relative_path() cp3. new_path='9dk'
```
2 years ago
SomberNight
58f041fd38
qt: fix window.donate_to_server to switch to send tab
...
probably regression from payment_identifier refactor
2 years ago
ghost43
e814fa0b25
Merge pull request #8719 from SomberNight/202312_db_seedtype
...
wallet db: deduplicate "seed_type" field
2 years ago
SomberNight
c98830d091
mac build: follow-up prev (altool -> notarytool migration)
...
related 7ee078852a
2 years ago
ThomasV
99da6507fc
osx builds: use notarytool
2 years ago