SomberNight
ee52154542
transaction: TxInput: store addr/spk/value_sats, instead of re-calc
...
We were re-calculating txin.address from the prevtx-utxo on every call,
e.g. in electrum/gui/qt/utxo_list.py#L103 (for every utxo in the wallet).
For a wallet with ~1300 utxos, UTXOList.update() took ~3.2 sec before this,
now it's ~0.8 sec.
3 years ago
SomberNight
312e50e9a9
qml: send screen: bip21: fallback to onchain addr if no LN channels
...
given a bip21 uri that has both onchain addr and bolt11,
if we have LN enabled but no LN channels, auto-fallback to paying onchain
we will have to clean up and unify this logic between GUIs. becoming spaghetti :/
rumour has it, Thomas has a branch? :P
3 years ago
SomberNight
5b122e723f
follow-up prev: re-add some newlines
3 years ago
SomberNight
55140a9e27
gui/messages.py: allow localization of these strings
3 years ago
Sander van Grieken
663ea431f6
followup 61179ede8c
3 years ago
Sander van Grieken
a23457f48d
qml: consistency camelcase pyqtProperties
3 years ago
Sander van Grieken
e26d49f11e
qml: consistency camelcase public slots qetxdetails, qelnpaymentdetails, qechannelopener, qeaddressdetails
3 years ago
Sander van Grieken
264540e12b
qml: consistency camelcase public slots qedaemon, qeinvoice, qewizard
3 years ago
Sander van Grieken
61179ede8c
qml: consistency camelcase qewallet
3 years ago
Sander van Grieken
f0bbbe9955
qml: consistency camelcase public slots listmodels
3 years ago
Sander van Grieken
2b091b283a
qml: qebitcoin remove unused code, fix scoping, camelcase
3 years ago
Sander van Grieken
96fd339a52
qml: followup 22fa84a0, use fixed font, use camelcase for QML properties
3 years ago
ghost43
664544886a
Merge pull request #8318 from SomberNight/202304_qt_bumpfee
...
qt bump fee: disallow targeting an abs fee. only allow setting feerate
3 years ago
SomberNight
22fa84a0d5
qml: ReceiveDialog: clicking QR code to show encoded text
...
closes https://github.com/spesmilo/electrum/issues/8331
3 years ago
SomberNight
adf976fef4
qml: QERequestDetails: use uppercase in bolt11 QR code
...
same trick as in other GUIs
3 years ago
SomberNight
bf41675d4c
qml: invoice/request list: flip sort order: newest on top
...
to be consistent with the History, and with other GUIs
(the model is the easiest place to do it. QSortFilterProxyModel/etc looks overkill)
3 years ago
Sander van Grieken
407769cb5f
qml: remove Scan.qml
3 years ago
Sander van Grieken
5ead4feabb
qml: wallet menu wider to fit wide translated texts
3 years ago
SomberNight
e097a3f875
CI: add some task dependencies
...
run linter first, then tests, then binary builds
3 years ago
ghost43
8ef395f4f3
Merge pull request #8337 from SomberNight/202304_flake8_bugbear
...
CI: flake8-bugbear
3 years ago
SomberNight
4cbb8399d2
CI: also run flake8-bugbear, as part of flake8
3 years ago
SomberNight
4219022c2e
fix flake8-bugbear B023
...
B023 Function definition does not bind loop variable 'already_selected_buckets_value_sum'
in keepkey/qt.py, looks like this was an actual bug
(fixed in trezor plugin already: 52a4810752 )
3 years ago
SomberNight
612d3493df
fix flake8-bugbear B017
...
B017 `assertRaises(Exception)` and `pytest.raises(Exception)` should be considered evil. They can lead to your test passing even if the code being tested is never executed due to a typo. Assert for a more specific exception (builtin or custom), or use `assertRaisesRegex` (if using `assertRaises`), or add the `match` keyword argument (if using `pytest.raises`), or use the context manager form with a target.
3 years ago
SomberNight
90315e72d6
fix flake8-bugbear B016
...
B016 Cannot raise a literal. Did you intend to return it or raise an Exception?
3 years ago
SomberNight
8266ebcc46
fix flake8-bugbear B008
...
B008 Do not perform function calls in argument defaults. The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call. If this is intended, assign the function call to a module-level variable and use that variable as a default value.
3 years ago
SomberNight
e2406f21b4
fix flake8-bugbear B011
...
B011 Do not call assert False since python -O removes these calls. Instead callers should raise AssertionError().
3 years ago
SomberNight
312f2641e7
don't use bare except
...
use "except Exception", or if really needed explicitly "except BaseException"
3 years ago
Sander van Grieken
6848b8f375
qml: refactor all custom QRScan component wrappers to ScanDialog
...
(except SendDialog, which has a Paste button and slightly different behavior)
3 years ago
Sander van Grieken
49df18c613
qml: add hint property to QRScan
3 years ago
Sander van Grieken
959d481e93
qml: create ScanDialog
3 years ago
Sander van Grieken
674c2b55e7
qml: small fixes
3 years ago
Sander van Grieken
2fc9ee5c51
p4a: fix for Qt5 accessibility bug
...
see 087fc3c583
3 years ago
SomberNight
b429992e77
wizard.py: don't use mutable default args
3 years ago
SomberNight
e9aad6896e
wizard.py: change stack to be per-instance
...
seems less error-prone
3 years ago
SomberNight
fd9a90f3b6
wizard.py: fix clearing stack between wizards
...
try finishing a wizard and then launching a new one: the new one kept
building on top of the stack of the prev wizard
3 years ago
SomberNight
417423ecd7
qt: PayToEdit: fix input_qr_from_camera
...
closes https://github.com/spesmilo/electrum/issues/8342
probably regression from 1f4cedf56a
3 years ago
SomberNight
a8623f63bb
qml: fix send "flow with LN but not LN enabled AND having bip21 uri"
...
closes https://github.com/spesmilo/electrum/issues/8334
3 years ago
SomberNight
7907eb1f86
qml/qeinvoice.py: turn _bip21 field into local var
3 years ago
SomberNight
6b75d5f134
qt SwapDialog: handle sm.max_amount_forward_swap() being None
...
closes https://github.com/spesmilo/electrum/issues/8341
3 years ago
SomberNight
ea864cd5c9
qml: TxListModel: don't rely on wallet.db.get_transaction() finding tx
...
tx might get removed from wallet after wallet.get_full_history() but before the model is populated
closes https://github.com/spesmilo/electrum/issues/8339
3 years ago
SomberNight
1a2d4494eb
qt: fix sweeping
...
closes https://github.com/spesmilo/electrum/issues/8340
regression from 2f6d60c715
3 years ago
SomberNight
ad58916729
wizard.py: (trivial) fix type hint and an f-string
3 years ago
SomberNight
6b0db411ae
wallet: save_db immediately after init_lightning() generates keys
...
Had a crash shortly after enabling lightning and the LN keys were lost...
Though note that opening a channel triggers wallet.save_db(), so I think
nothing of real value is at risk without this change.
3 years ago
ThomasV
0fcf423fbe
Revert "lnworker: schedule_force_closing is not async"
...
This reverts commit fcf836bc94 .
3 years ago
ThomasV
fcf836bc94
lnworker: schedule_force_closing is not async
3 years ago
ThomasV
f787d6eede
qt piechart: show a full circle if there is only one item in the list
3 years ago
Sander van Grieken
0d536b83ba
qml: ignore update() when wallet not set yet. closes #8330
3 years ago
Sander van Grieken
7383cdc474
qml: don't crash when tx not found on histogram event. closes #8332
3 years ago
SomberNight
75a9a4fce9
qml TxDetails: txid must be updated after rawtx is changed
...
refresh bug when using bump_fee/dscancel/etc
3 years ago
SomberNight
2ec4758a12
qml: follow-up fix for offline-signing pre-segwit tx
...
follow-up 3cec6cdcfb
3 years ago