From fffbc178cd33d1d1f4c2a7a65cfb541103cab757 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Wed, 14 Feb 2024 09:05:21 +0000 Subject: [PATCH] qt wizard: hww dialogs: log some exceptions more aggressively sort of related: https://github.com/spesmilo/electrum/issues/8892 --- electrum/gui/qt/wizard/wallet.py | 4 ++-- electrum/plugins/bitbox02/qt.py | 1 + electrum/plugins/keepkey/qt.py | 1 + electrum/plugins/safe_t/qt.py | 1 + electrum/plugins/trezor/qt.py | 1 + 5 files changed, 6 insertions(+), 2 deletions(-) diff --git a/electrum/gui/qt/wizard/wallet.py b/electrum/gui/qt/wizard/wallet.py index dbe4beb50..7bcc7bdae 100644 --- a/electrum/gui/qt/wizard/wallet.py +++ b/electrum/gui/qt/wizard/wallet.py @@ -1296,7 +1296,7 @@ class WCHWUnlock(WalletWizardComponent, Logger): self.password = client.get_password_for_storage_encryption() except Exception as e: self.error = repr(e) # TODO: handle user interaction exceptions (e.g. invalid pin) more gracefully - self.logger.error(repr(e)) + self.logger.exception(repr(e)) self.busy = False self.validate() @@ -1386,7 +1386,7 @@ class WCHWXPub(WalletWizardComponent, Logger): self.logger.error(repr(e)) except Exception as e: self.error = repr(e) # TODO: handle user interaction exceptions (e.g. invalid pin) more gracefully - self.logger.error(repr(e)) + self.logger.exception(repr(e)) self.logger.debug(f'Done retrieve xpub: {self.xpub}') self.busy = False self.validate() diff --git a/electrum/plugins/bitbox02/qt.py b/electrum/plugins/bitbox02/qt.py index 4e8df221d..fe9fb1c32 100644 --- a/electrum/plugins/bitbox02/qt.py +++ b/electrum/plugins/bitbox02/qt.py @@ -149,6 +149,7 @@ class WCBitbox02ScriptAndDerivation(WCScriptAndDerivation): self.error = str(e) except Exception as e: self.error = repr(e) + self.logger.exception(repr(e)) finally: self.busy = False diff --git a/electrum/plugins/keepkey/qt.py b/electrum/plugins/keepkey/qt.py index 198b2375c..785e9b2f9 100644 --- a/electrum/plugins/keepkey/qt.py +++ b/electrum/plugins/keepkey/qt.py @@ -684,6 +684,7 @@ class WCKeepkeyInit(WizardComponent, Logger): except Exception as e: self.valid = False self.error = repr(e) + self.logger.exception(repr(e)) finally: self.busy = False diff --git a/electrum/plugins/safe_t/qt.py b/electrum/plugins/safe_t/qt.py index 40f778989..9f03f4521 100644 --- a/electrum/plugins/safe_t/qt.py +++ b/electrum/plugins/safe_t/qt.py @@ -616,6 +616,7 @@ class WCSafeTInit(WizardComponent, Logger): except Exception as e: self.valid = False self.error = repr(e) + self.logger.exception(repr(e)) finally: self.busy = False diff --git a/electrum/plugins/trezor/qt.py b/electrum/plugins/trezor/qt.py index 1d6716676..056011ca8 100644 --- a/electrum/plugins/trezor/qt.py +++ b/electrum/plugins/trezor/qt.py @@ -901,6 +901,7 @@ class WCTrezorInit(WizardComponent, Logger): except Exception as e: self.valid = False self.error = repr(e) + self.logger.exception(repr(e)) finally: self.busy = False