From de5ca461d4aef45b95e1589e85c2517af831829a Mon Sep 17 00:00:00 2001 From: ThomasV Date: Fri, 15 Mar 2024 10:57:26 +0100 Subject: [PATCH] contrib/osx: - rename make_osx2.sh -> sign_osx.sh - add command to unlock keychain - chmod +x --- contrib/osx/README.md | 4 ++-- contrib/osx/make_osx.sh | 2 +- contrib/osx/{make_osx2.sh => sign_osx.sh} | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) rename contrib/osx/{make_osx2.sh => sign_osx.sh} (98%) mode change 100644 => 100755 diff --git a/contrib/osx/README.md b/contrib/osx/README.md index a34188f25..5428f09a6 100644 --- a/contrib/osx/README.md +++ b/contrib/osx/README.md @@ -91,13 +91,13 @@ This creates both a folder named Electrum.app and the .dmg file (both unsigned). ##### 2.1. For release binaries, here be dragons If you want the binaries codesigned for macOS and notarised by Apple's central server, -also run the `make_osx2.sh` script: +also run the `sign_osx.sh` script: CODESIGN_CERT="Developer ID Application: Electrum Technologies GmbH (L6P37P7P56)" \ APPLE_TEAM_ID="L6P37P7P56" \ APPLE_ID_USER="me@email.com" \ APPLE_ID_PASSWORD="1234" \ - ./contrib/osx/make_osx2.sh + ./contrib/osx/sign_osx.sh (note: `APPLE_ID_PASSWORD` is an app-specific password, *not* the account password) diff --git a/contrib/osx/make_osx.sh b/contrib/osx/make_osx.sh index b04b32ef8..161998991 100755 --- a/contrib/osx/make_osx.sh +++ b/contrib/osx/make_osx.sh @@ -213,4 +213,4 @@ info "Creating unsigned .DMG" hdiutil create -fs HFS+ -volname $PACKAGE -srcfolder dist/$PACKAGE.app dist/electrum-$VERSION-unsigned.dmg || fail "Could not create .DMG" info "App was built successfully but was not code signed. Users may get security warnings from macOS." -info "Now you also need to run make_osx2.sh to codesign/notarize the binary." +info "Now you also need to run sign_osx.sh to codesign/notarize the binary." diff --git a/contrib/osx/make_osx2.sh b/contrib/osx/sign_osx.sh old mode 100644 new mode 100755 similarity index 98% rename from contrib/osx/make_osx2.sh rename to contrib/osx/sign_osx.sh index 09500468f..785f3b8e9 --- a/contrib/osx/make_osx2.sh +++ b/contrib/osx/sign_osx.sh @@ -2,6 +2,8 @@ set -e +security -v unlock-keychain login.keychain + PACKAGE=Electrum