From dbc695ba4a7f262d51da0aee5b08140dfa5d97e9 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Wed, 4 May 2022 19:58:16 +0200 Subject: [PATCH] follow-up prev MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Windows build was failing due to the trailing slash in the path: ``` 💬 INFO: Pip installing Electrum. This might take a long time if the project folder is large. Processing c:\electrum Preparing metadata (setup.py): started Preparing metadata (setup.py): finished with status 'error' error: subprocess-exited-with-error python setup.py egg_info did not run successfully. exit code: 1 [10 lines of output] Traceback (most recent call last): File "", line 2, in File "", line 34, in File "C:\electrum\setup.py", line 75, in find_packages('electrum/', exclude=["tests", "gui.kivy", "gui.kivy.*"])]), File "C:\python3\lib\site-packages\setuptools\discovery.py", line 103, in find convert_path(str(where)), File "C:\python3\lib\site-packages\setuptools\_distutils\util.py", line 130, in convert_path raise ValueError("path '%s' cannot end with '/'" % pathname) ValueError: path 'electrum/' cannot end with '/' ``` This is weird because I tested the setuptools.find_packages invocation on Linux, where it has no issues with the trailing slash, but indeed it looks like on Windows it does. Not sure why it behaves differently depending on the platform. Anyway, removing. --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 2c661629c..642408792 100755 --- a/setup.py +++ b/setup.py @@ -72,7 +72,7 @@ setup( extras_require=extras_require, packages=(['electrum',] + [('electrum.'+pkg) for pkg in - find_packages('electrum/', exclude=["tests", "gui.kivy", "gui.kivy.*"])]), + find_packages('electrum', exclude=["tests", "gui.kivy", "gui.kivy.*"])]), package_dir={ 'electrum': 'electrum' },