From d0c37c6e33366ff982fb3a2c6de0fb0c785ec950 Mon Sep 17 00:00:00 2001 From: Sander van Grieken Date: Fri, 23 Feb 2024 11:11:12 +0100 Subject: [PATCH] qml: refactor help text in CpfpBumpFeeDialog, move most to help text popup --- electrum/gui/qml/components/CpfpBumpFeeDialog.qml | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/electrum/gui/qml/components/CpfpBumpFeeDialog.qml b/electrum/gui/qml/components/CpfpBumpFeeDialog.qml index 3e95fe99f..15ac6dcd2 100644 --- a/electrum/gui/qml/components/CpfpBumpFeeDialog.qml +++ b/electrum/gui/qml/components/CpfpBumpFeeDialog.qml @@ -41,18 +41,15 @@ ElDialog { columns: 2 Label { - Layout.columnSpan: 2 Layout.fillWidth: true - text: qsTr('A CPFP is a transaction that sends an unconfirmed output back to yourself, with a high fee. The goal is to have miners confirm the parent transaction in order to get the fee attached to the child transaction.') + text: qsTr('A CPFP is a transaction that sends an unconfirmed output back to yourself, with a high fee.') wrapMode: Text.Wrap } - Label { - Layout.columnSpan: 2 - Layout.fillWidth: true - Layout.bottomMargin: constants.paddingLarge - text: qsTr('The proposed fee is computed using your fee/kB settings, applied to the total size of both child and parent transactions. After you broadcast a CPFP transaction, it is normal to see a new unconfirmed transaction in your history.') - wrapMode: Text.Wrap + HelpButton { + heading: qsTr('CPFP - Child Pays For Parent') + helptext: qsTr('A CPFP is a transaction that sends an unconfirmed output back to yourself, with a high fee. The goal is to have miners confirm the parent transaction in order to get the fee attached to the child transaction.') + + '

' + qsTr('The proposed fee is computed using your fee/vkB settings, applied to the total size of both child and parent transactions. After you broadcast a CPFP transaction, it is normal to see a new unconfirmed transaction in your history.') } Label {