From c348d4d7ce18acd2f2d0fff3970ab85f5e7669f5 Mon Sep 17 00:00:00 2001
From: Sander van Grieken <sander@outrightsolutions.nl>
Date: Fri, 1 Sep 2023 15:08:01 +0200
Subject: [PATCH] follow-up 0a804607a4d03c78ba80a2c2a1c51bccdf9ea509, don't ask
 confirmation for regular onchain invoices

---
 .../gui/qml/components/WalletMainView.qml     | 26 +++++++++++--------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/electrum/gui/qml/components/WalletMainView.qml b/electrum/gui/qml/components/WalletMainView.qml
index 915c659d3..c0a954d5a 100644
--- a/electrum/gui/qml/components/WalletMainView.qml
+++ b/electrum/gui/qml/components/WalletMainView.qml
@@ -360,18 +360,22 @@ Item {
                         lninvoiceButPayOnchain = true
                     }
                 }
-                if (invoice.invoiceType == Invoice.OnchainInvoice || lninvoiceButPayOnchain) {
-                    var dialog = app.messageDialog.createObject(mainView, {
-                        title: qsTr('Insufficient balance to pay over Lightning. Pay on-chain instead?'),
-                        yesno: true
-                    })
-                    dialog.accepted.connect(function() {
-                        payOnchain()
-                    })
-                    dialog.open()
+                if (invoice.invoiceType == Invoice.OnchainInvoice) {
+                    payOnchain()
                 } else if (invoice.invoiceType == Invoice.LightningInvoice) {
-                    console.log('About to pay lightning invoice')
-                    invoice.payLightningInvoice()
+                    if (lninvoiceButPayOnchain) {
+                        var dialog = app.messageDialog.createObject(mainView, {
+                            title: qsTr('Insufficient balance to pay over Lightning. Pay on-chain instead?'),
+                            yesno: true
+                        })
+                        dialog.accepted.connect(function() {
+                            payOnchain()
+                        })
+                        dialog.open()
+                    } else {
+                        console.log('About to pay lightning invoice')
+                        invoice.payLightningInvoice()
+                    }
                 }
             }