From bb2e4109422dc46652bc6579bcfc8149e3c86758 Mon Sep 17 00:00:00 2001 From: ThomasV Date: Thu, 21 Apr 2022 12:16:33 +0200 Subject: [PATCH] Do not reuse addresses of expired requests. Since expired requests are user-visible, it is very confusing that they get replaced when the user creates a new request. --- electrum/wallet.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/electrum/wallet.py b/electrum/wallet.py index a06fb6d97..1993c8d7e 100644 --- a/electrum/wallet.py +++ b/electrum/wallet.py @@ -2122,9 +2122,7 @@ class Abstract_Wallet(AddressSynchronizer, ABC): domain = self.get_receiving_addresses() # TODO we should index receive_requests by id # add lightning requests. (use as key) - in_use_by_request = [k for k in self.receive_requests.keys() - if self.get_request_status(k) != PR_EXPIRED] - in_use_by_request = set(in_use_by_request) + in_use_by_request = set(self.receive_requests.keys()) return [addr for addr in domain if not self.is_used(addr) and addr not in in_use_by_request]