From ae12d236b297b74afc9566625cda1b14aa477a11 Mon Sep 17 00:00:00 2001 From: Sander van Grieken Date: Thu, 4 May 2023 01:14:40 +0200 Subject: [PATCH] qml: fix broadcastFailed signal connections in txdetails (fixes #8384) --- electrum/gui/qml/qetxdetails.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/electrum/gui/qml/qetxdetails.py b/electrum/gui/qml/qetxdetails.py index 8ff2cc6b2..914ae96eb 100644 --- a/electrum/gui/qml/qetxdetails.py +++ b/electrum/gui/qml/qetxdetails.py @@ -322,7 +322,7 @@ class QETxDetails(QObject, QtEventListener): try: if broadcast: self._wallet.broadcastSucceeded.disconnect(self.onBroadcastSucceeded) - self._wallet.broadcastfailed.disconnect(self.onBroadcastFailed) + self._wallet.broadcastFailed.disconnect(self.onBroadcastFailed) except Exception: pass @@ -343,7 +343,7 @@ class QETxDetails(QObject, QtEventListener): assert self._tx.is_complete() try: - self._wallet.broadcastfailed.disconnect(self.onBroadcastFailed) + self._wallet.broadcastFailed.disconnect(self.onBroadcastFailed) except Exception: pass self._wallet.broadcastFailed.connect(self.onBroadcastFailed) @@ -359,7 +359,10 @@ class QETxDetails(QObject, QtEventListener): return self._logger.debug('onBroadcastSucceeded') - self._wallet.broadcastSucceeded.disconnect(self.onBroadcastSucceeded) + try: + self._wallet.broadcastSucceeded.disconnect(self.onBroadcastSucceeded) + except Exception: + pass self._can_broadcast = False self.detailsChanged.emit()