diff --git a/electrum/gui/qml/components/ConfirmTxDialog.qml b/electrum/gui/qml/components/ConfirmTxDialog.qml index 1dc5b22c9..e1241fbe6 100644 --- a/electrum/gui/qml/components/ConfirmTxDialog.qml +++ b/electrum/gui/qml/components/ConfirmTxDialog.qml @@ -17,9 +17,6 @@ ElDialog { property alias amountLabelText: amountLabel.text property alias sendButtonText: sendButton.text - signal txcancelled - signal txaccepted - title: qsTr('Confirm Transaction') // copy these to finalizer @@ -223,12 +220,9 @@ ElDialog { : qsTr('Pay') icon.source: '../../icons/confirmed.png' enabled: finalizer.valid - onClicked: { - txaccepted() - dialog.close() - } + onClicked: doAccept() } } - onClosed: txcancelled() + onClosed: doReject() } diff --git a/electrum/gui/qml/components/CpfpBumpFeeDialog.qml b/electrum/gui/qml/components/CpfpBumpFeeDialog.qml index a81c235a6..94811b27d 100644 --- a/electrum/gui/qml/components/CpfpBumpFeeDialog.qml +++ b/electrum/gui/qml/components/CpfpBumpFeeDialog.qml @@ -13,8 +13,6 @@ ElDialog { required property string txid required property QtObject cpfpfeebumper - signal txaccepted - title: qsTr('Bump Fee') iconSource: Qt.resolvedUrl('../../icons/rocket.png') @@ -224,17 +222,14 @@ ElDialog { text: qsTr('Ok') icon.source: '../../icons/confirmed.png' enabled: cpfpfeebumper.valid - onClicked: { - txaccepted() - dialog.close() - } + onClicked: doAccept() } } Connections { target: cpfpfeebumper function onTxMined() { - dialog.close() + dialog.doReject() } } } diff --git a/electrum/gui/qml/components/OpenChannelDialog.qml b/electrum/gui/qml/components/OpenChannelDialog.qml index 1870d8186..51a1b104c 100644 --- a/electrum/gui/qml/components/OpenChannelDialog.qml +++ b/electrum/gui/qml/components/OpenChannelDialog.qml @@ -202,7 +202,7 @@ ElDialog { var dialog = confirmOpenChannelDialog.createObject(app, { 'satoshis': channelopener.amount }) - dialog.txaccepted.connect(function() { + dialog.accepted.connect(function() { dialog.finalizer.signAndSend() }) dialog.open() diff --git a/electrum/gui/qml/components/RbfBumpFeeDialog.qml b/electrum/gui/qml/components/RbfBumpFeeDialog.qml index 0d05b118d..e613b46d6 100644 --- a/electrum/gui/qml/components/RbfBumpFeeDialog.qml +++ b/electrum/gui/qml/components/RbfBumpFeeDialog.qml @@ -13,8 +13,6 @@ ElDialog { required property string txid required property QtObject rbffeebumper - signal txaccepted - title: qsTr('Bump Fee') iconSource: Qt.resolvedUrl('../../icons/rocket.png') @@ -237,17 +235,14 @@ ElDialog { text: qsTr('Ok') icon.source: '../../icons/confirmed.png' enabled: rbffeebumper.valid - onClicked: { - txaccepted() - dialog.close() - } + onClicked: doAccept() } } Connections { target: rbffeebumper function onTxMined() { - dialog.close() + dialog.doReject() } } } diff --git a/electrum/gui/qml/components/RbfCancelDialog.qml b/electrum/gui/qml/components/RbfCancelDialog.qml index 9238592e4..b6727e96c 100644 --- a/electrum/gui/qml/components/RbfCancelDialog.qml +++ b/electrum/gui/qml/components/RbfCancelDialog.qml @@ -13,8 +13,6 @@ ElDialog { required property string txid required property QtObject txcanceller - signal txaccepted - title: qsTr('Cancel Transaction') width: parent.width @@ -207,17 +205,14 @@ ElDialog { text: qsTr('Ok') icon.source: '../../icons/confirmed.png' enabled: txcanceller.valid - onClicked: { - txaccepted() - dialog.close() - } + onClicked: doAccept() } } Connections { target: txcanceller function onTxMined() { - dialog.close() + dialog.doReject() } } } diff --git a/electrum/gui/qml/components/TxDetails.qml b/electrum/gui/qml/components/TxDetails.qml index 0a2878dcb..723d5e395 100644 --- a/electrum/gui/qml/components/TxDetails.qml +++ b/electrum/gui/qml/components/TxDetails.qml @@ -440,7 +440,7 @@ Pane { wallet: Daemon.currentWallet txid: dialog.txid } - onTxaccepted: { + onAccepted: { root.rawtx = rbffeebumper.getNewTx() if (txdetails.wallet.canSignWithoutCosigner) { txdetails.sign_and_broadcast() @@ -465,7 +465,7 @@ Pane { txid: dialog.txid } - onTxaccepted: { + onAccepted: { // replaces parent tx with cpfp tx root.rawtx = cpfpfeebumper.getNewTx() if (txdetails.wallet.canSignWithoutCosigner) { @@ -491,7 +491,7 @@ Pane { txid: dialog.txid } - onTxaccepted: { + onAccepted: { root.rawtx = txcanceller.getNewTx() if (txdetails.wallet.canSignWithoutCosigner) { txdetails.sign_and_broadcast() diff --git a/electrum/gui/qml/components/WalletMainView.qml b/electrum/gui/qml/components/WalletMainView.qml index 921e5a117..3e0501977 100644 --- a/electrum/gui/qml/components/WalletMainView.qml +++ b/electrum/gui/qml/components/WalletMainView.qml @@ -328,7 +328,7 @@ Item { message: invoice.message }) var canComplete = !Daemon.currentWallet.isWatchOnly && Daemon.currentWallet.canSignWithoutCosigner - dialog.txaccepted.connect(function() { + dialog.accepted.connect(function() { if (!canComplete) { if (Daemon.currentWallet.isWatchOnly) { dialog.finalizer.save()