From 9ab18ea6c915102129368a8bf7a7cbde6ed7104a Mon Sep 17 00:00:00 2001 From: SomberNight Date: Tue, 25 Feb 2020 21:14:41 +0100 Subject: [PATCH] transaction.deserialize: more sanity checks this is mandated by consensus https://github.com/bitcoin/bitcoin/blob/99813a9745fe10a58bedd7a4cb721faf14f907a4/src/consensus/tx_check.cpp#L13 --- electrum/transaction.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/electrum/transaction.py b/electrum/transaction.py index 908bda7af..af7789d34 100644 --- a/electrum/transaction.py +++ b/electrum/transaction.py @@ -564,8 +564,12 @@ class Transaction: if marker != b'\x01': raise ValueError('invalid txn marker byte: {}'.format(marker)) n_vin = vds.read_compact_size() + if n_vin < 1: + raise SerializationError('tx needs to have at least 1 input') self._inputs = [parse_input(vds) for i in range(n_vin)] n_vout = vds.read_compact_size() + if n_vout < 1: + raise SerializationError('tx needs to have at least 1 output') self._outputs = [parse_output(vds) for i in range(n_vout)] if is_segwit: for txin in self._inputs: