From 9599254d437d762420d6eaf9163c54d0452af0b1 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Mon, 9 May 2022 20:09:10 +0200 Subject: [PATCH] hw: rm dead code from Hardware_KeyStore subclasses - force_watching_only is long since unused - comment was just duplicated from the base class --- electrum/plugins/bitbox02/bitbox02.py | 1 - electrum/plugins/coldcard/coldcard.py | 4 ---- electrum/plugins/digitalbitbox/digitalbitbox.py | 1 - electrum/plugins/ledger/ledger.py | 4 ---- 4 files changed, 10 deletions(-) diff --git a/electrum/plugins/bitbox02/bitbox02.py b/electrum/plugins/bitbox02/bitbox02.py index 767231bf7..a3c940c17 100644 --- a/electrum/plugins/bitbox02/bitbox02.py +++ b/electrum/plugins/bitbox02/bitbox02.py @@ -559,7 +559,6 @@ class BitBox02_KeyStore(Hardware_KeyStore): def __init__(self, d: dict): super().__init__(d) - self.force_watching_only = False self.ux_busy = False def get_client(self) -> Optional['BitBox02Client']: diff --git a/electrum/plugins/coldcard/coldcard.py b/electrum/plugins/coldcard/coldcard.py index 5e9339c1e..c60d924e9 100644 --- a/electrum/plugins/coldcard/coldcard.py +++ b/electrum/plugins/coldcard/coldcard.py @@ -251,10 +251,6 @@ class Coldcard_KeyStore(Hardware_KeyStore): def __init__(self, d): Hardware_KeyStore.__init__(self, d) - # Errors and other user interaction is done through the wallet's - # handler. The handler is per-window and preserved across - # device reconnects - self.force_watching_only = False self.ux_busy = False # we need to know at least the fingerprint of the master xpub to verify against MiTM diff --git a/electrum/plugins/digitalbitbox/digitalbitbox.py b/electrum/plugins/digitalbitbox/digitalbitbox.py index 1b9b27340..d1e42a0f5 100644 --- a/electrum/plugins/digitalbitbox/digitalbitbox.py +++ b/electrum/plugins/digitalbitbox/digitalbitbox.py @@ -442,7 +442,6 @@ class DigitalBitbox_KeyStore(Hardware_KeyStore): def __init__(self, d): Hardware_KeyStore.__init__(self, d) - self.force_watching_only = False self.maxInputs = 14 # maximum inputs per single sign command def give_error(self, message, clear_client = False): diff --git a/electrum/plugins/ledger/ledger.py b/electrum/plugins/ledger/ledger.py index e9c953bf4..bc5e3e3e6 100644 --- a/electrum/plugins/ledger/ledger.py +++ b/electrum/plugins/ledger/ledger.py @@ -246,10 +246,6 @@ class Ledger_KeyStore(Hardware_KeyStore): def __init__(self, d): Hardware_KeyStore.__init__(self, d) - # Errors and other user interaction is done through the wallet's - # handler. The handler is per-window and preserved across - # device reconnects - self.force_watching_only = False self.signing = False self.cfg = d.get('cfg', {'mode': 0})