From 8ccc4801f7b3aa8b5d0ba83f2b8783500f471faa Mon Sep 17 00:00:00 2001 From: Sander van Grieken Date: Fri, 10 Feb 2023 13:28:27 +0100 Subject: [PATCH] qml: ConfirmTxDialog styling slider, avoid running off small screens --- electrum/gui/qml/components/ConfirmTxDialog.qml | 5 +++-- electrum/gui/qml/components/WalletMainView.qml | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/electrum/gui/qml/components/ConfirmTxDialog.qml b/electrum/gui/qml/components/ConfirmTxDialog.qml index 2c539ba8b..73097766f 100644 --- a/electrum/gui/qml/components/ConfirmTxDialog.qml +++ b/electrum/gui/qml/components/ConfirmTxDialog.qml @@ -174,8 +174,9 @@ ElDialog { InfoTextArea { Layout.columnSpan: 2 - Layout.preferredWidth: parent.width * 3/4 - Layout.alignment: Qt.AlignHCenter + Layout.fillWidth: true + Layout.topMargin: constants.paddingLarge + Layout.bottomMargin: constants.paddingLarge visible: finalizer.warning != '' text: finalizer.warning iconStyle: InfoTextArea.IconStyle.Warn diff --git a/electrum/gui/qml/components/WalletMainView.qml b/electrum/gui/qml/components/WalletMainView.qml index 09fe37deb..569e17e43 100644 --- a/electrum/gui/qml/components/WalletMainView.qml +++ b/electrum/gui/qml/components/WalletMainView.qml @@ -327,6 +327,10 @@ Item { _confirmPaymentDialog.destroy() } } + // TODO: lingering confirmPaymentDialogs can raise exceptions in + // the child finalizer when currentWallet disappears, but we need + // it long enough for the finalizer to finish.. + // onClosed: destroy() } }