From 77c2d4ec06095fdff7adbb9e1d9430a1b11a42f7 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Mon, 26 Sep 2022 17:57:50 +0000 Subject: [PATCH] mac build: note in README: pyinstaller picks up extraneous brew pkgs ThomasV had libffi installed via brew, and this side-effected the built electrum dmg. `('libffi.8.dylib', '/usr/local/opt/libffi/lib/libffi.8.dylib', 'BINARY')` this was the cause of https://github.com/spesmilo/electrum/commit/019d213325312badc55d95a6cabc6278dda47a8a --- contrib/osx/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/osx/README.md b/contrib/osx/README.md index 204ef2f35..6737708d7 100644 --- a/contrib/osx/README.md +++ b/contrib/osx/README.md @@ -57,6 +57,9 @@ Before starting, you should install [`brew`](https://brew.sh/). $ xcrun --show-sdk-path /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk ``` +- Installing extraneous brew packages can result in build differences. + For example, pyinstaller seems to pick up and bundle brew-installed `libffi`. + So having a dedicated "electrum binary builder macOS VM" is recommended. - Make sure that you are building from a fresh clone of electrum (or run e.g. `git clean -ffxd` to rm all local changes).