From 54f7755397f5c4a4ce3215ddad70f342f06cf9fe Mon Sep 17 00:00:00 2001 From: SomberNight Date: Thu, 11 Mar 2021 18:51:45 +0100 Subject: [PATCH] lnpeer.maybe_forward_htlc: add FIXME --- electrum/lnpeer.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/electrum/lnpeer.py b/electrum/lnpeer.py index 781a5c216..eac79eb97 100644 --- a/electrum/lnpeer.py +++ b/electrum/lnpeer.py @@ -1343,6 +1343,9 @@ class Peer(Logger): # Forward HTLC # FIXME: there are critical safety checks MISSING here + # - for example; atm we forward first and then persist "forwarding_info", + # so if we segfault in-between and restart, we might forward an HTLC twice... + # (same for trampoline forwarding) forwarding_enabled = self.network.config.get('lightning_forward_payments', False) if not forwarding_enabled: self.logger.info(f"forwarding is disabled. failing htlc.")