From 2be71c2dcc34f499930975487b85a72d7958bfe8 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Fri, 21 Apr 2023 16:38:58 +0000 Subject: [PATCH] windows README: update reference to libsecp256k1-0.dll to incl newer related: https://github.com/spesmilo/electrum/pull/8185 --- .cirrus.yml | 4 ++-- contrib/build-wine/README_windows.md | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 34cb5e60f..d68194dc8 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -41,7 +41,7 @@ task: - git tag install_script: - apt-get update - - apt-get -y install libsecp256k1-0 + - apt-get -y install libsecp256k1-dev - pip install -r $ELECTRUM_REQUIREMENTS_CI tox_script: - export PYTHONASYNCIODEBUG @@ -101,7 +101,7 @@ task: populate_script: mkdir -p /tmp/bitcoind install_script: - apt-get update - - apt-get -y install libsecp256k1-0 curl jq bc + - apt-get -y install libsecp256k1-dev curl jq bc - pip3 install .[tests] # install e-x some commits after 1.16.0 tag, where it uses same aiorpcx as electrum - pip3 install git+https://github.com/spesmilo/electrumx.git@c8d2cc0d5cf9e549a90ca876d85fed9a90b8c4ed diff --git a/contrib/build-wine/README_windows.md b/contrib/build-wine/README_windows.md index 82c0efca9..a34cce1f9 100644 --- a/contrib/build-wine/README_windows.md +++ b/contrib/build-wine/README_windows.md @@ -23,7 +23,8 @@ Run install (this should install most dependencies): [libsecp256k1](https://github.com/bitcoin-core/secp256k1) is a required dependency. This is a C library, which you need to compile yourself. -Electrum needs a dll, named `libsecp256k1-0.dll`, placed into the inner `electrum/` folder. +Electrum needs a dll, named `libsecp256k1-0.dll` (or newer `libsecp256k1-*.dll`), +placed into the inner `electrum/` folder. For Unix-like systems, the (`contrib/make_libsecp256k1.sh`) script does this for you, however it does not work on Windows. @@ -53,7 +54,7 @@ Alternatively, MSYS2 and MinGW-w64 can be used directly on Windows, as follows. (note: this is a bit cumbersome, see [issue #5976](https://github.com/spesmilo/electrum/issues/5976) for discussion) -### 3. Run electrum: +### 3. Run electrum: ``` > python3 ./run_electrum