From 11bf084a1f836c6f82b4eca8910ba79194357ff2 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Tue, 18 Sep 2018 01:40:34 +0200 Subject: [PATCH] network triggers: 'verified' notification now includes wallet this is a performance optimisation. measurements using a large wallet with 11k txns: syncing XPUB for the first time takes 10 seconds. leaving window open, and syncing same XPUB again in new window takes 30 seconds. in third window, it takes ~50 seconds. then ~70s. presumably scaling linearly. this is due to the history_list.update_item call being CPU-heavy. now all of them take 10 seconds. --- electrum/address_synchronizer.py | 2 +- electrum/gui/qt/main_window.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/electrum/address_synchronizer.py b/electrum/address_synchronizer.py index 7a58f531c..3afe85b39 100644 --- a/electrum/address_synchronizer.py +++ b/electrum/address_synchronizer.py @@ -593,7 +593,7 @@ class AddressSynchronizer(PrintError): self.unverified_tx.pop(tx_hash, None) self.verified_tx[tx_hash] = info tx_mined_status = self.get_tx_height(tx_hash) - self.network.trigger_callback('verified', tx_hash, tx_mined_status) + self.network.trigger_callback('verified', self, tx_hash, tx_mined_status) def get_unverified_txs(self): '''Returns a map from tx hash to transaction height''' diff --git a/electrum/gui/qt/main_window.py b/electrum/gui/qt/main_window.py index a4885303a..0564a58b1 100644 --- a/electrum/gui/qt/main_window.py +++ b/electrum/gui/qt/main_window.py @@ -316,7 +316,9 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, PrintError): elif event == 'banner': self.console.showMessage(args[0]) elif event == 'verified': - self.history_list.update_item(*args) + wallet, tx_hash, tx_mined_status = args + if wallet == self.wallet: + self.history_list.update_item(tx_hash, tx_mined_status) elif event == 'fee': if self.config.is_dynfee(): self.fee_slider.update()