From 03778b6e0c503d15dc2d852e3cac6f75b381db72 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Thu, 30 Nov 2023 19:31:14 +0000 Subject: [PATCH] add FIXMEs to instances where we don't use the network proxy so that it at least does not get forgotten related https://github.com/spesmilo/electrum/issues/4754 --- electrum/dnssec.py | 1 + electrum/plugins/cosigner_pool/qt.py | 1 + electrum/util.py | 1 + 3 files changed, 3 insertions(+) diff --git a/electrum/dnssec.py b/electrum/dnssec.py index 8a678b6df..dc2bfa2e5 100644 --- a/electrum/dnssec.py +++ b/electrum/dnssec.py @@ -137,6 +137,7 @@ def _get_and_validate(ns, url, _type): def query(url, rtype): + # FIXME this method is not using the network proxy. (although the proxy might not support UDP?) # 8.8.8.8 is Google's public DNS server nameservers = ['8.8.8.8'] ns = nameservers[0] diff --git a/electrum/plugins/cosigner_pool/qt.py b/electrum/plugins/cosigner_pool/qt.py index 30fac677b..87ab21282 100644 --- a/electrum/plugins/cosigner_pool/qt.py +++ b/electrum/plugins/cosigner_pool/qt.py @@ -53,6 +53,7 @@ if TYPE_CHECKING: ca_path = certifi.where() ssl_context = ssl.create_default_context(purpose=ssl.Purpose.SERVER_AUTH, cafile=ca_path) server = ServerProxy('https://cosigner.electrum.org/', allow_none=True, context=ssl_context) +# FIXME this is not using the network proxy. class Listener(util.DaemonThread): diff --git a/electrum/util.py b/electrum/util.py index ab0626646..dc6b28074 100644 --- a/electrum/util.py +++ b/electrum/util.py @@ -1707,6 +1707,7 @@ def list_enabled_bits(x: int) -> Sequence[int]: def resolve_dns_srv(host: str): + # FIXME this method is not using the network proxy. (although the proxy might not support UDP?) srv_records = dns.resolver.resolve(host, 'SRV') # priority: prefer lower # weight: tie breaker; prefer higher